[AN] 비회원 관리 #595
Merged
[AN] 비회원 관리 #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
이제부터는 모든 바텀 버튼을 누르면 로그인 화면이 뜹니다.
…igongil into AN/feature/574-guest
…igongil into AN/feature/574-guest
s9hn
approved these changes
Oct 31, 2023
| @@ -27,8 +27,8 @@ class GuestViewModel @Inject constructor( | |||
| private val _refreshState: MutableLiveData<Boolean> = MutableLiveData<Boolean>() | |||
| val refreshState: LiveData<Boolean> get() = _refreshState | |||
|
|
|||
| fun refresh() { | |||
| _refreshState.value = true | |||
| fun refresh(isRefreshed: Boolean) { | |||
| @@ -141,6 +147,13 @@ class MainActivity : BindingActivity<ActivityMainBinding>(R.layout.activity_main | |||
| } | |||
| } | |||
|
|
|||
| private fun showLoginBottomSheetDialog() { | |||
| LoginBottomSheetFragment().show( | |||
There was a problem hiding this comment.
얘는 매번 생성안하고 한번만 생성해도 되지 않나요? 진짜궁금
There was a problem hiding this comment.
엇 그렇네요.
굳이 안해줘도 되네요.
인스턴스 한번만 생성하게 바꿨습니다 ~
| @@ -256,6 +254,9 @@ class StudyListFragment : | |||
| studyListViewModel.updateIsGuest(mainViewModel.isGuest) | |||
| val filter = getStudyListFilter(group) | |||
| studyListViewModel.loadFilteredPage(filter) | |||
| if (mainViewModel.isGuest and filter.isGuestOnly()) { | |||
There was a problem hiding this comment.
요즘 python 많이 썻더니..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😋 작업한 내용
🙏 PR Point
비회원 기능이라는 화면 표시 및 화면 클릭 시 로그인 바텀시트를 보여줌
비회원은 스터디 목록 화면만 볼 수 있음.
다른 바텀버튼을 클릭하염 로그인 바텀시트를 보여주고, 로그인 하지 않을 시 스터디 목록을 그대로 다시 보여줍니다.
혹시 이 방식이 별로라고 생각하면 다시 rollback 할 생각도 있으니 의견주세요.
👍 관련 이슈