-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile stories block - part 4: error handling #13103
Merged
mzorz
merged 84 commits into
feature/jetpack-stories-block-base
from
try/jetpack-stories-block-error-handling
Oct 23, 2020
Merged
Mobile stories block - part 4: error handling #13103
mzorz
merged 84 commits into
feature/jetpack-stories-block-base
from
try/jetpack-stories-block-error-handling
Oct 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzorz
added
[Type] Enhancement
Gutenberg
Editing and display of Gutenberg blocks.
gutenberg-mobile
labels
Oct 11, 2020
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
This was referenced Oct 11, 2020
You can test the changes on this Pull Request by downloading the APK here. |
6 tasks
…n based block Story block
…n udpating id or url
…wing message that saving cannot be cancelled
…ement it right now)
…t better represents the changes on the WPAndroid side of things (was changed before to the more generic StoryFrameMediaIdChangeEvent which is used in the bridge)
Generated by 🚫 dangerJS |
…as it may have been replaced by Double with final remote mediaIds
WordPress/src/test/java/org/wordpress/android/ui/stories/SaveStoryGutenbergBlockUseCaseTest.kt
Outdated
Show resolved
Hide resolved
...c/test/java/org/wordpress/android/ui/stories/usecase/LoadStoryFromStoriesPrefsUseCaseTest.kt
Outdated
Show resolved
Hide resolved
...c/test/java/org/wordpress/android/ui/stories/usecase/LoadStoryFromStoriesPrefsUseCaseTest.kt
Outdated
Show resolved
Hide resolved
...c/test/java/org/wordpress/android/ui/stories/usecase/LoadStoryFromStoriesPrefsUseCaseTest.kt
Outdated
Show resolved
Hide resolved
...c/test/java/org/wordpress/android/ui/stories/usecase/LoadStoryFromStoriesPrefsUseCaseTest.kt
Outdated
Show resolved
Hide resolved
...c/test/java/org/wordpress/android/ui/stories/usecase/LoadStoryFromStoriesPrefsUseCaseTest.kt
Outdated
Show resolved
Hide resolved
...c/test/java/org/wordpress/android/ui/stories/usecase/LoadStoryFromStoriesPrefsUseCaseTest.kt
Outdated
Show resolved
Hide resolved
...c/test/java/org/wordpress/android/ui/stories/usecase/LoadStoryFromStoriesPrefsUseCaseTest.kt
Outdated
Show resolved
Hide resolved
...c/test/java/org/wordpress/android/ui/stories/usecase/LoadStoryFromStoriesPrefsUseCaseTest.kt
Outdated
Show resolved
Hide resolved
…se/LoadStoryFromStoriesPrefsUseCaseTest.kt Co-authored-by: Joel Dean <[email protected]>
…toryGutenbergBlockUseCaseTest.kt Co-authored-by: Joel Dean <[email protected]>
…ies-listener-move-from-editpostactivity
jd-alexander
approved these changes
Oct 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these tests @mzorz all is well from my side. LGTM 🚢
…move-from-editpostactivity Mobile stories block - error handling 4.1 - move code out of EditPostActivity
…ck commit hashes respectively
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #13101
This contains all the work needed in order to provide error situation handling when saving or uploading any of the media related to a Story block.
To test:
CASE A: error in saves
CASE B: error in upload.
Related PRs:
Gutenberg mobile: wordpress-mobile/gutenberg-mobile#2708
Gutenberg: WordPress/gutenberg#26008
Jetpack: Automattic/jetpack#17458
PR submission checklist:
RELEASE-NOTES.txt
if necessary.