Bump androidxCameraVersion from 1.2.3 to 1.3.0 #19687

dependabot · 2023-11-29T08:29:58Z

Bumps androidxCameraVersion from 1.2.3 to 1.3.0.
Updates androidx.camera:camera-camera2 from 1.2.3 to 1.3.0

Updates androidx.camera:camera-lifecycle from 1.2.3 to 1.3.0

Updates androidx.camera:camera-view from 1.2.3 to 1.3.0

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `androidxCameraVersion` from 1.2.3 to 1.3.0. Updates `androidx.camera:camera-camera2` from 1.2.3 to 1.3.0 Updates `androidx.camera:camera-lifecycle` from 1.2.3 to 1.3.0 Updates `androidx.camera:camera-view` from 1.2.3 to 1.3.0 --- updated-dependencies: - dependency-name: androidx.camera:camera-camera2 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: androidx.camera:camera-lifecycle dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: androidx.camera:camera-view dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

peril-wordpress-mobile · 2023-11-29T08:30:04Z

	Fails
🚫	This PR is tagged with 'Do Not Merge' label.

Generated by 🚫 dangerJS

wpmobilebot · 2023-11-29T08:37:03Z

Found 1 violations:

The PR caused the following dependency changes:

 +--- androidx.webkit:webkit:1.7.0
 |    \--- androidx.core:core:1.1.0 -> 1.10.0
-|         \--- androidx.annotation:annotation-experimental:1.3.0
+|         \--- androidx.annotation:annotation-experimental:1.3.0 -> 1.3.1
 +--- project :libs:analytics
 |    \--- androidx.preference:preference:1.2.0
 |         \--- androidx.appcompat:appcompat:1.1.0 -> 1.6.1
 |              \--- androidx.fragment:fragment:1.3.6 -> 1.6.2
-|                   \--- androidx.annotation:annotation-experimental:1.0.0 -> 1.3.0 (*)
+|                   \--- androidx.annotation:annotation-experimental:1.0.0 -> 1.3.1 (*)
 +--- project :libs:image-editor
 |    +--- com.google.android.material:material:1.9.0
-|    |    \--- androidx.annotation:annotation-experimental:1.0.0 -> 1.3.0 (*)
+|    |    \--- androidx.annotation:annotation-experimental:1.0.0 -> 1.3.1 (*)
 |    +--- androidx.navigation:navigation-fragment:2.5.3
 |    |    \--- androidx.navigation:navigation-runtime:2.5.3
-|    |         \--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.0 (*)
+|    |         \--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.1 (*)
 |    \--- androidx.navigation:navigation-ui:2.5.3
-|         \--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.0 (*)
+|         \--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.1 (*)
 +--- org.wordpress:fluxc:{strictly 2.57.0} -> 2.57.0
 |    \--- androidx.room:room-runtime:2.4.2 -> 2.5.0
-|         \--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.0 (*)
+|         \--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.1 (*)
 +--- com.automattic:about:1.3.0
 |    \--- androidx.navigation:navigation-compose:2.4.0-beta02
 |         \--- androidx.lifecycle:lifecycle-viewmodel-compose:2.4.0-rc01 -> 2.6.2
-|              \--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.0 (*)
+|              \--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.1 (*)
 +--- com.automattic:stories:2.4.0
 |    \--- com.automattic.stories:photoeditor:2.4.0
-|         +--- androidx.camera:camera-core:1.0.0-alpha06 -> 1.2.3
-|         |    +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
-|         |    +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.0 (*)
-|         |    +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
-|         |    +--- androidx.core:core:1.1.0 -> 1.10.0 (*)
-|         |    +--- androidx.exifinterface:exifinterface:1.3.2 -> 1.3.6 (*)
-|         |    +--- androidx.lifecycle:lifecycle-common:2.1.0 -> 2.6.2 (*)
-|         |    +--- androidx.lifecycle:lifecycle-livedata:2.1.0 -> 2.6.2 (*)
-|         |    +--- com.google.auto.value:auto-value-annotations:1.6.3
-|         |    +--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.10 (*)
+|         +--- androidx.camera:camera-core:1.0.0-alpha06 -> 1.3.0
+|         |    +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
+|         |    +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.1 (*)
+|         |    +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
+|         |    +--- androidx.core:core:1.1.0 -> 1.10.0 (*)
+|         |    +--- androidx.exifinterface:exifinterface:1.3.2 -> 1.3.6 (*)
+|         |    +--- androidx.lifecycle:lifecycle-common:2.1.0 -> 2.6.2 (*)
+|         |    +--- androidx.lifecycle:lifecycle-livedata:2.1.0 -> 2.6.2 (*)
+|         |    +--- com.google.auto.value:auto-value-annotations:1.6.3
+|         |    +--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
+|         |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.10 (*)
+|         |    +--- androidx.camera:camera-camera2:1.3.0 (c)
+|         |    +--- androidx.camera:camera-lifecycle:1.3.0 (c)
+|         |    +--- androidx.camera:camera-video:1.3.0 (c)
+|         |    \--- androidx.camera:camera-view:1.3.0 (c)
-|         \--- androidx.camera:camera-camera2:1.0.0-alpha06 -> 1.2.3
-|              +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
-|              +--- androidx.camera:camera-core:1.2.3 (*)
-|              +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
-|              +--- androidx.core:core:1.1.0 -> 1.10.0 (*)
-|              +--- com.google.auto.value:auto-value-annotations:1.6.3
-|              \--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
+|         \--- androidx.camera:camera-camera2:1.0.0-alpha06 -> 1.3.0
+|              +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
+|              +--- androidx.camera:camera-core:1.3.0 (*)
+|              +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
+|              +--- androidx.core:core:1.1.0 -> 1.10.0 (*)
+|              +--- com.google.auto.value:auto-value-annotations:1.6.3
+|              +--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
+|              +--- androidx.camera:camera-core:1.3.0 (c)
+|              +--- androidx.camera:camera-lifecycle:1.3.0 (c)
+|              +--- androidx.camera:camera-view:1.3.0 (c)
+|              \--- androidx.camera:camera-video:1.3.0 (c)
 +--- androidx.work:work-runtime:2.8.1
-|    \--- androidx.annotation:annotation-experimental:1.0.0 -> 1.3.0 (*)
+|    \--- androidx.annotation:annotation-experimental:1.0.0 -> 1.3.1 (*)
-+--- androidx.camera:camera-camera2:1.2.3 (*)
++--- androidx.camera:camera-camera2:1.3.0 (*)
-+--- androidx.camera:camera-lifecycle:1.2.3
-|    +--- androidx.camera:camera-core:1.2.3 (*)
-|    +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
-|    +--- androidx.core:core:1.1.0 -> 1.10.0 (*)
-|    +--- androidx.lifecycle:lifecycle-common:2.1.0 -> 2.6.2 (*)
-|    +--- com.google.auto.value:auto-value-annotations:1.6.3
-|    \--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
++--- androidx.camera:camera-lifecycle:1.3.0
+|    +--- androidx.camera:camera-core:1.3.0 (*)
+|    +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
+|    +--- androidx.core:core:1.1.0 -> 1.10.0 (*)
+|    +--- androidx.lifecycle:lifecycle-common:2.1.0 -> 2.6.2 (*)
+|    +--- com.google.auto.value:auto-value-annotations:1.6.3
+|    +--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
+|    +--- androidx.camera:camera-camera2:1.3.0 (c)
+|    +--- androidx.camera:camera-core:1.3.0 (c)
+|    +--- androidx.camera:camera-view:1.3.0 (c)
+|    \--- androidx.camera:camera-video:1.3.0 (c)
-\--- androidx.camera:camera-view:1.2.3
-     +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
-     +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.0 (*)
-     +--- androidx.appcompat:appcompat:1.1.0 -> 1.6.1 (*)
-     +--- androidx.camera:camera-core:1.2.3 (*)
-     +--- androidx.camera:camera-lifecycle:1.2.3 (*)
-     +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
-     +--- androidx.core:core:1.3.2 -> 1.10.0 (*)
-     +--- androidx.lifecycle:lifecycle-common:2.0.0 -> 2.6.2 (*)
-     +--- com.google.auto.value:auto-value-annotations:1.6.3
-     \--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
+\--- androidx.camera:camera-view:1.3.0
+     +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
+     +--- androidx.annotation:annotation-experimental:1.3.1 (*)
+     +--- androidx.appcompat:appcompat:1.1.0 -> 1.6.1 (*)
+     +--- androidx.camera:camera-core:1.3.0 (*)
+     +--- androidx.camera:camera-lifecycle:1.3.0 (*)
+     +--- androidx.camera:camera-video:1.3.0
+     |    +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
+     |    +--- androidx.camera:camera-core:1.3.0 (*)
+     |    +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
+     |    +--- androidx.core:core:1.1.0 -> 1.10.0 (*)
+     |    +--- com.google.auto.value:auto-value-annotations:1.6.3
+     |    +--- androidx.camera:camera-camera2:1.3.0 (c)
+     |    +--- androidx.camera:camera-core:1.3.0 (c)
+     |    +--- androidx.camera:camera-lifecycle:1.3.0 (c)
+     |    \--- androidx.camera:camera-view:1.3.0 (c)
+     +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
+     +--- androidx.core:core:1.3.2 -> 1.10.0 (*)
+     +--- androidx.lifecycle:lifecycle-common:2.0.0 -> 2.6.2 (*)
+     +--- com.google.auto.value:auto-value-annotations:1.6.3
+     +--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
+     +--- androidx.camera:camera-camera2:1.3.0 (c)
+     +--- androidx.camera:camera-core:1.3.0 (c)
+     +--- androidx.camera:camera-lifecycle:1.3.0 (c)
+     \--- androidx.camera:camera-video:1.3.0 (c)

Please review and act accordingly

antonis · 2023-11-29T11:56:14Z

Checking the introduced changes in version 1.3.0 compared to the previous version 1.2.3 there are several improvements and bug fixes. From the changes in the API the one that affected the app is the following:

Deprecated the legacy setTargetAspectRatio and setTargetResolution API. Please use the new ResolutionSelector API instead. (I542c3)

As a first step I've suppressed the deprecation warning with ff71bf7

wpmobilebot · 2023-11-29T12:01:55Z

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

wpmobilebot · 2023-11-29T12:14:59Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19687-ff71bf7
	Commit	`ff71bf7`
	Direct Download	`jetpack-prototype-build-pr19687-ff71bf7.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2023-11-29T12:16:14Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19687-ff71bf7
	Commit	`ff71bf7`
	Direct Download	`wordpress-prototype-build-pr19687-ff71bf7.apk`

Note: Google Login is not supported on these builds.

antonis

I've tested the implementation and everything worked as expected for the QR code login flow that is affected by the dependency change.
Note that I needed to suppress a warning with ff71bf7 to make the app compile after the following deprecation:

Deprecated the legacy setTargetAspectRatio and setTargetResolution API. Please use the new ResolutionSelector API instead. (I542c3)

We should adapt our implementation to use the suggested ResolutionSelector but this can be part of a different PR.

@zwarm I think the changes are safe but wanted to give you a heads up before merging since you are more familiar with this part of the code.

antonis · 2023-11-30T15:30:03Z

Adding the Do Not Merge label till we resolve the issue discussed at #19695 (comment)

zwarm · 2023-12-06T20:12:10Z

Adding the Do Not Merge label till we resolve the issue discussed at #19695 (comment)

Thanks for the callout @antonis , but we can't upgrade in the app until stories-android is updated. And updating stories-android is not a straight forward change and is a bigger effort than a hack week. I started researching, but put it aside for the focus on crashes. It might make sense to have a separate project for stories itself; as I also encountered several security issues related to permissions (noted in this Automattic/stories-android#743). The library hasn't been updated since 2021 (except for config files). It's overdue for some love.

P.S. I did start a branch [update/camerax](https://github.com/Automattic/stories-android/tree/update/camerax) based off of multiple upgrade PRs, but didn't get very far because of the shift in direction :(

antonis · 2023-12-07T09:30:01Z

we can't upgrade in the app until stories-android is updated.

This makes sense to me 👍

The library hasn't been updated since 2021 (except for config files). It's overdue for some love.

True 😐

I'll close this PR and we can aim to the latest available version for the stories upgrade along with the main app.

dependabot · 2023-12-07T09:30:05Z

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot bot added the bot: dependencies update PRs that update a dependency file, used by Dependabot. label Nov 29, 2023

dependabot bot requested review from a team and mkevins and removed request for a team November 29, 2023 08:30

antonis self-requested a review November 29, 2023 08:37

Suppress camera setTargetResolution method deprecation

ff71bf7

antonis added this to the 23.9 milestone Nov 29, 2023

antonis approved these changes Nov 29, 2023

View reviewed changes

antonis added the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label Nov 30, 2023

antonis mentioned this pull request Dec 1, 2023

RuntimeException: Unable to start activity ComponentInfo{com.jetpack.android/org.wordpress.android.ui.stories.Story... #19695

Closed

antonis closed this Dec 7, 2023

dependabot bot deleted the dependabot/gradle/androidxCameraVersion-1.3.0 branch December 7, 2023 09:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump androidxCameraVersion from 1.2.3 to 1.3.0 #19687

Bump androidxCameraVersion from 1.2.3 to 1.3.0 #19687

dependabot bot commented on behalf of github Nov 29, 2023

peril-wordpress-mobile bot commented Nov 29, 2023 •

edited

Loading

wpmobilebot commented Nov 29, 2023

antonis commented Nov 29, 2023

wpmobilebot commented Nov 29, 2023

wpmobilebot commented Nov 29, 2023

wpmobilebot commented Nov 29, 2023

antonis left a comment •

edited

Loading

antonis commented Nov 30, 2023

zwarm commented Dec 6, 2023 •

edited

Loading

antonis commented Dec 7, 2023

dependabot bot commented on behalf of github Dec 7, 2023

Bump androidxCameraVersion from 1.2.3 to 1.3.0 #19687

Bump androidxCameraVersion from 1.2.3 to 1.3.0 #19687

Conversation

dependabot bot commented on behalf of github Nov 29, 2023

peril-wordpress-mobile bot commented Nov 29, 2023 • edited Loading

wpmobilebot commented Nov 29, 2023

The PR caused the following dependency changes:

antonis commented Nov 29, 2023

wpmobilebot commented Nov 29, 2023

wpmobilebot commented Nov 29, 2023

wpmobilebot commented Nov 29, 2023

antonis left a comment • edited Loading

Choose a reason for hiding this comment

antonis commented Nov 30, 2023

zwarm commented Dec 6, 2023 • edited Loading

antonis commented Dec 7, 2023

dependabot bot commented on behalf of github Dec 7, 2023

peril-wordpress-mobile bot commented Nov 29, 2023 •

edited

Loading

antonis left a comment •

edited

Loading

zwarm commented Dec 6, 2023 •

edited

Loading