Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lib] Update wordpress-utils for testing targetSdk update. #19999

Closed
wants to merge 1 commit into from

Conversation

notandyvee
Copy link
Contributor

Fixes:

Update Wordpress-Utils using a lib generated by this PR: wordpress-mobile/WordPress-Utils-Android#141


To Test:

  • 🚬 test the app to ensure the wp-utils update didn't cause issues.

Regression Notes

  1. Potential unintended areas of impact

    • General 🚬 testing.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Getting permissions
    • Adding images
    • Posting blog
    • Editing Post
    • Viewing reader
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused the following dependency changes:

-\--- org.wordpress:utils:{strictly 3.11.0} -> 3.11.0
+\--- org.wordpress:utils:{strictly 141-e3b4df5b0e54124184d8bb89682e80edc8ec0f0b} -> 141-e3b4df5b0e54124184d8bb89682e80edc8ec0f0b

Please review and act accordingly

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19999-38eb0c1
Commit38eb0c1
Direct Downloadwordpress-prototype-build-pr19999-38eb0c1.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19999-38eb0c1
Commit38eb0c1
Direct Downloadjetpack-prototype-build-pr19999-38eb0c1.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Update the wordPressUtilsVersion to a trunk or release version before merging

@notandyvee
Copy link
Contributor Author

Closing in favor of this one: #20032

@notandyvee notandyvee closed this Jan 25, 2024
@jkmassel jkmassel deleted the wp-utils-141-update branch October 17, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants