-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dark mode in Zendesk chat #21486
Conversation
Generated by 🚫 Danger |
Project dependencies changesThe following changes in project dependencies were detected (configuration list
tree-\--- com.zendesk:support:5.1.2
- +--- com.zendesk:support-providers:5.1.2
- | +--- com.zendesk:core:4.0.9
- | | +--- com.zendesk:java-common:2.0.0
- | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 2.0.21 (*)
- | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
- | | +--- com.google.dagger:dagger:2.42 -> 2.52 (*)
- | | +--- com.squareup.retrofit2:retrofit:2.9.0 -> 2.11.0 (*)
- | | +--- com.squareup.retrofit2:converter-gson:2.9.0
- | | | +--- com.squareup.retrofit2:retrofit:2.9.0 -> 2.11.0 (*)
- | | | \--- com.google.code.gson:gson:2.8.5 -> 2.11.0 (*)
- | | +--- com.squareup.okhttp3:logging-interceptor:4.9.2
- | | | +--- com.squareup.okhttp3:okhttp:4.9.2 -> 4.12.0 (*)
- | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.9.10 (*)
- | | +--- com.squareup.okhttp3:okhttp:4.9.2 -> 4.12.0 (*)
- | | +--- androidx.annotation:annotation:1.3.0 -> 1.9.1 (*)
- | | \--- com.jakewharton:disklrucache:2.0.2
- | +--- com.zendesk:guide-providers:1.1.1
- | | +--- com.zendesk:core:4.0.9 (*)
- | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
- | | +--- com.google.dagger:dagger:2.42 -> 2.52 (*)
- | | +--- androidx.annotation:annotation:1.3.0 -> 1.9.1 (*)
- | | +--- com.squareup.retrofit2:retrofit:2.9.0 -> 2.11.0 (*)
- | | \--- com.google.code.gson:gson:2.8.9 -> 2.11.0 (*)
- | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
- | +--- com.google.dagger:dagger:2.42 -> 2.52 (*)
- | +--- androidx.annotation:annotation:1.3.0 -> 1.9.1 (*)
- | +--- com.squareup.retrofit2:retrofit:2.9.0 -> 2.11.0 (*)
- | \--- com.google.code.gson:gson:2.8.9 -> 2.11.0 (*)
- +--- com.zendesk:guide:1.1.1
- | +--- com.zendesk:guide-providers:1.1.1 (*)
- | +--- com.zendesk:sdk-configurations:2.0.3
- | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
- | | +--- com.zendesk:java-common:2.0.0 (*)
- | | \--- androidx.annotation:annotation:1.3.0 -> 1.9.1 (*)
- | +--- com.zendesk:messaging-api:5.3.0
- | | +--- com.zendesk:sdk-configurations:2.0.3 (*)
- | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
- | | +--- com.zendesk:java-common:2.0.0 (*)
- | | \--- androidx.annotation:annotation:1.3.0 -> 1.9.1 (*)
- | +--- com.zendesk:messaging:5.3.0
- | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
- | | +--- com.zendesk:messaging-api:5.3.0 (*)
- | | +--- com.zendesk:common-ui:4.0.5
- | | | +--- com.zendesk:java-common:2.0.0 (*)
- | | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
- | | | +--- com.zendesk.belvedere2:belvedere:3.0.5
- | | | | +--- com.zendesk.belvedere2:belvedere-core:3.0.5
- | | | | | +--- androidx.annotation:annotation:1.1.0 -> 1.9.1 (*)
- | | | | | +--- androidx.core:core:1.3.1 -> 1.13.1 (*)
- | | | | | \--- androidx.fragment:fragment:1.2.5 -> 1.8.5 (*)
- | | | | +--- androidx.annotation:annotation:1.1.0 -> 1.9.1 (*)
- | | | | +--- androidx.core:core:1.3.1 -> 1.13.1 (*)
- | | | | +--- androidx.fragment:fragment:1.2.5 -> 1.8.5 (*)
- | | | | +--- com.google.android.material:material:1.2.0 -> 1.12.0 (*)
- | | | | \--- com.squareup.picasso:picasso:2.8
- | | | | +--- com.squareup.okhttp3:okhttp:3.10.0 -> 4.12.0 (*)
- | | | | +--- androidx.annotation:annotation:1.0.0 -> 1.9.1 (*)
- | | | | \--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.7 (*)
- | | | +--- androidx.appcompat:appcompat:1.0.0 -> 1.7.0 (*)
- | | | +--- com.google.android.material:material:1.4.0 -> 1.12.0 (*)
- | | | +--- androidx.cardview:cardview:1.0.0 (*)
- | | | \--- com.squareup.picasso:picasso:2.8 (*)
- | | +--- com.google.dagger:dagger:2.42 -> 2.52 (*)
- | | +--- com.zendesk.belvedere2:belvedere:3.0.5 (*)
- | | +--- androidx.appcompat:appcompat:1.0.0 -> 1.7.0 (*)
- | | +--- com.google.android.material:material:1.4.0 -> 1.12.0 (*)
- | | +--- com.google.android.flexbox:flexbox:3.0.0 (*)
- | | \--- com.squareup.picasso:picasso:2.8 (*)
- | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
- | +--- com.google.dagger:dagger-android:2.42 -> 2.52 (*)
- | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
- | +--- androidx.appcompat:appcompat -> 1.7.0 (*)
- | +--- androidx.recyclerview:recyclerview -> 1.3.2 (*)
- | +--- com.google.android.material:material:1.4.0 -> 1.12.0 (*)
- | +--- androidx.cardview:cardview:1.0.0 (*)
- | +--- com.squareup.okhttp3:okhttp:4.9.2 -> 4.12.0 (*)
- | \--- com.google.code.gson:gson:2.8.9 -> 2.11.0 (*)
- +--- com.zendesk:sdk-configurations:2.0.3 (*)
- +--- com.zendesk:messaging-api:5.3.0 (*)
- +--- com.zendesk:messaging:5.3.0 (*)
- +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
- +--- com.google.dagger:dagger-android:2.42 -> 2.52 (*)
- +--- androidx.multidex:multidex:2.0.0
- +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
- +--- androidx.appcompat:appcompat:1.0.0 -> 1.7.0 (*)
- +--- androidx.recyclerview:recyclerview -> 1.3.2 (*)
- +--- com.google.android.material:material:1.4.0 -> 1.12.0 (*)
- +--- androidx.cardview:cardview -> 1.0.0 (*)
- +--- com.jakewharton:disklrucache:2.0.2
- +--- com.squareup.picasso:picasso:2.8 (*)
- +--- com.zendesk.belvedere2:belvedere:3.0.5 (*)
- \--- com.google.code.gson:gson:2.8.9 -> 2.11.0 (*)
+\--- com.zendesk:support:5.3.1
+ +--- com.google.android.material:material:1.4.0 -> 1.12.0 (*)
+ +--- androidx.appcompat:appcompat:1.7.0 (*)
+ +--- androidx.cardview:cardview:1.0.0 (*)
+ +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+ +--- androidx.multidex:multidex:2.0.0
+ +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.2 (*)
+ +--- com.google.dagger:dagger-android:2.48.1 -> 2.52 (*)
+ +--- com.jakewharton:disklrucache:2.0.2
+ +--- com.google.code.gson:gson:2.10.1 -> 2.11.0 (*)
+ +--- com.squareup.picasso:picasso:2.8
+ | +--- com.squareup.okhttp3:okhttp:3.10.0 -> 4.12.0 (*)
+ | +--- androidx.annotation:annotation:1.0.0 -> 1.9.1 (*)
+ | \--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.7 (*)
+ +--- androidx.activity:activity:1.9.1 -> 1.9.3 (*)
+ +--- androidx.fragment:fragment:1.8.2 -> 1.8.5 (*)
+ +--- com.zendesk:guide:1.3.1
+ | +--- com.google.android.material:material:1.4.0 -> 1.12.0 (*)
+ | +--- androidx.appcompat:appcompat:1.7.0 (*)
+ | +--- androidx.cardview:cardview:1.0.0 (*)
+ | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+ | +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.2 (*)
+ | +--- com.google.dagger:dagger-android:2.48.1 -> 2.52 (*)
+ | +--- com.google.code.gson:gson:2.10.1 -> 2.11.0 (*)
+ | +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+ | +--- com.zendesk:guide-providers:1.3.0
+ | | +--- androidx.annotation:annotation:1.3.0 -> 1.9.1 (*)
+ | | +--- com.google.dagger:dagger:2.48.1 -> 2.52 (*)
+ | | +--- com.google.code.gson:gson:2.10.1 -> 2.11.0 (*)
+ | | +--- com.squareup.retrofit2:retrofit:2.11.0 (*)
+ | | +--- com.zendesk:core:4.2.0
+ | | | +--- androidx.annotation:annotation:1.3.0 -> 1.9.1 (*)
+ | | | +--- androidx.legacy:legacy-support-core-utils:1.0.0 (*)
+ | | | +--- com.google.dagger:dagger:2.48.1 -> 2.52 (*)
+ | | | +--- com.jakewharton:disklrucache:2.0.2
+ | | | +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+ | | | +--- com.squareup.okhttp3:logging-interceptor:4.12.0
+ | | | | +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+ | | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
+ | | | +--- com.squareup.retrofit2:retrofit:2.11.0 (*)
+ | | | +--- com.squareup.retrofit2:converter-gson:2.11.0
+ | | | | +--- com.squareup.retrofit2:retrofit:2.11.0 (*)
+ | | | | \--- com.google.code.gson:gson:2.10.1 -> 2.11.0 (*)
+ | | | +--- com.zendesk:java-common:2.0.0
+ | | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 2.0.21 (*)
+ | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.0.21 (*)
+ | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.0.21 (*)
+ | +--- com.zendesk:messaging:5.5.1
+ | | +--- com.google.android.material:material:1.4.0 -> 1.12.0 (*)
+ | | +--- androidx.appcompat:appcompat:1.7.0 (*)
+ | | +--- androidx.core:core-ktx:1.9.0 -> 1.13.1 (*)
+ | | +--- com.google.dagger:dagger:2.48.1 -> 2.52 (*)
+ | | +--- com.google.android.flexbox:flexbox:3.0.0 (*)
+ | | +--- com.squareup.picasso:picasso:2.8 (*)
+ | | +--- com.zendesk:common-ui:4.2.1
+ | | | +--- com.google.android.material:material:1.4.0 -> 1.12.0 (*)
+ | | | +--- androidx.appcompat:appcompat:1.7.0 (*)
+ | | | +--- androidx.cardview:cardview:1.0.0 (*)
+ | | | +--- androidx.core:core-ktx:1.9.0 -> 1.13.1 (*)
+ | | | +--- com.squareup.picasso:picasso:2.8 (*)
+ | | | +--- com.zendesk:java-common:2.0.0 (*)
+ | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.0.21 (*)
+ | | +--- com.zendesk:messaging-api:5.5.0
+ | | | +--- androidx.annotation:annotation:1.3.0 -> 1.9.1 (*)
+ | | | +--- com.zendesk:java-common:2.0.0 (*)
+ | | | +--- com.zendesk:sdk-configurations:2.2.0
+ | | | | +--- androidx.annotation:annotation:1.3.0 -> 1.9.1 (*)
+ | | | | +--- com.zendesk:java-common:2.0.0 (*)
+ | | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.0.21 (*)
+ | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.0.21 (*)
+ | | +--- com.zendesk:core:4.2.0 (*)
+ | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.0.21 (*)
+ | +--- com.zendesk:messaging-api:5.5.0 (*)
+ | +--- com.zendesk:sdk-configurations:2.2.0 (*)
+ | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.0.21 (*)
+ +--- com.zendesk:messaging:5.5.1 (*)
+ +--- com.zendesk:sdk-configurations:2.2.0 (*)
+ +--- com.zendesk:support-providers:5.3.0
+ | +--- androidx.annotation:annotation:1.3.0 -> 1.9.1 (*)
+ | +--- com.google.dagger:dagger:2.48.1 -> 2.52 (*)
+ | +--- com.google.code.gson:gson:2.10.1 -> 2.11.0 (*)
+ | +--- com.squareup.retrofit2:retrofit:2.11.0 (*)
+ | +--- com.zendesk:core:4.2.0 (*)
+ | +--- com.zendesk:guide-providers:1.3.0 (*)
+ | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.0.21 (*)
+ \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.0.21 (*) |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quality Gate passedIssues Measures |
Unfortunately, the same fix won't work for that screen ( |
Fixes #21485
Previously Zendesk chat would show with light mode colors even in dark mode. This PR addresses this.
To test:
Note: Dark mode support is only available in Android 33 (Tiramisu) and above.