-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes the unit tests for Xcode 13. #17382
Fixes the unit tests for Xcode 13. #17382
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
@diegoreymendez JFYI this is already being handled here: #17233 |
Generated by 🚫 dangerJS |
Thanks for the ping @leandroalonso, since I was so close to finishing this today, I just wrapped it up. I sent you an @mokagio a DM to see what we want to do with it. |
Superseded by #17391 |
IMPORTANT NOTE: I tackled this issue because I had already updated to Xcode 13 a while ago and it was becoming a little bit annoying on my end to test for breaking changes in Xcode 12 vs 13. I wasn't aware there was an ongoing effort to get this sorted, so apologies to @leandroalonso and @mokagio for duplicating part of the effort.
This PR does NOT address updating the CIs Xcode version (which is indeed handled by the PR you're working on). So we could see this PR as a temporary band-aid before the other PR is ready, if we wanted it.
That said, I'd encourage us to consider merging this PR as it resolves the biggest issue right away (which is our ability to build the tests in Xcode 13, for those of us who're already using it).
Description:
This PR fixes the compatibility issues brought forward by Xcode 13 making the unit tests compile and run successfully again (both in Xcode 12 and 13).
The approach is minimalistic to try and get this core issue resolved quickly.
To test:
Run the unit tests in Xcode 13
Make sure the tests succeed since they're using Xcode 12
Regression Notes
None.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.