Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the unit tests for Xcode 13. #17382

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Oct 28, 2021

IMPORTANT NOTE: I tackled this issue because I had already updated to Xcode 13 a while ago and it was becoming a little bit annoying on my end to test for breaking changes in Xcode 12 vs 13. I wasn't aware there was an ongoing effort to get this sorted, so apologies to @leandroalonso and @mokagio for duplicating part of the effort.

This PR does NOT address updating the CIs Xcode version (which is indeed handled by the PR you're working on). So we could see this PR as a temporary band-aid before the other PR is ready, if we wanted it.

That said, I'd encourage us to consider merging this PR as it resolves the biggest issue right away (which is our ability to build the tests in Xcode 13, for those of us who're already using it).

Description:

This PR fixes the compatibility issues brought forward by Xcode 13 making the unit tests compile and run successfully again (both in Xcode 12 and 13).

The approach is minimalistic to try and get this core issue resolved quickly.

To test:

Run the unit tests in Xcode 13
Make sure the tests succeed since they're using Xcode 12

Regression Notes

  1. Potential unintended areas of impact

None.

  1. What I did to test those areas of impact (or what existing automated tests I relied on)
  2. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 28, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 28, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@leandroalonso
Copy link
Contributor

@diegoreymendez JFYI this is already being handled here: #17233

@diegoreymendez diegoreymendez changed the title Tries fixing the unit tests for Xcode 13. Fixes the unit tests for Xcode 13. Oct 28, 2021
@diegoreymendez diegoreymendez marked this pull request as ready for review October 29, 2021 00:32
@diegoreymendez diegoreymendez self-assigned this Oct 29, 2021
@diegoreymendez diegoreymendez added this to the 18.6 milestone Oct 29, 2021
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@diegoreymendez
Copy link
Contributor Author

Thanks for the ping @leandroalonso, since I was so close to finishing this today, I just wrapped it up. I sent you an @mokagio a DM to see what we want to do with it.

@diegoreymendez
Copy link
Contributor Author

diegoreymendez commented Oct 29, 2021

Superseded by #17391

@leandroalonso leandroalonso deleted the try/fix-core-data-mock-context-tests-for-xcode-13 branch October 29, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants