Added Type Declarations for TypeScript Support and Better IntelliSense #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…param doc to the module init function for wordnet.js
|
Looks like I did a few things wrong. Don't need some of the files and the package.json needs to define where the type declarations can be found. Pushed the fixes. I'll open the pull request again. |
… the type declarations can be found
… as an array; after verifying the actual type, it shouldn't have been declared as an array; instead, the lookup function returns a Promise<Definition[]> instead of just a Promise<Definition>
|
can I ask why none merged this PR?, it is very useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the help of @joelyjoel 's issue, I added type declarations to the project. The majority of the work was done by @joelyjoel . It was just a matter of updating it to match the current version of the project and adding a couple of small improvements to make the IntelliSense work great with the Definition object that's returned from the lookup method.