Skip to content

Commit

Permalink
Update rip.go
Browse files Browse the repository at this point in the history
  • Loading branch information
kayla-glick authored Dec 23, 2024
1 parent c0b8631 commit 3758924
Showing 1 changed file with 2 additions and 13 deletions.
15 changes: 2 additions & 13 deletions sim/druid/rip.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,18 +52,7 @@ var ripRanks = []RipRankInfo{
},
}

// See https://www.wowhead.com/classic/spell=436895/s03-tuning-and-overrides-passive-druid
// Modifies Buff Duration +4001:
// Modifies Periodic Damage/Healing Done +51%:
// const RipTicks int32 = 6
const RipTicks int32 = 8
const RipBaseDamageMultiplier = 1.5

// See https://www.wowhead.com/classic/news/development-notes-for-phase-4-ptr-season-of-discovery-new-runes-class-changes-342896
// - Rake and Rip damage contributions from attack power increased by roughly 50%.
// PTR testing comes out to .0165563 AP scaling per CP
// damageCoefPerCP := 0.01
const RipDamageCoefPerAPPerCP = 0.015
const RipTicks int32 = 6

func (druid *Druid) registerRipSpell() {
// Add highest available Rip rank for level.
Expand Down Expand Up @@ -116,7 +105,7 @@ func (druid *Druid) newRipSpellConfig(ripRank RipRankInfo) core.SpellConfig {
ap := dot.Spell.MeleeAttackPower()

cpScaling := core.TernaryFloat64(cp == 5, 4, cp)
baseDamage := (ripRank.dmgTickBase + ripRank.dmgTickPerCombo*cp + RipDamageCoefPerAPPerCP*ap*cpScaling)
baseDamage := (ripRank.dmgTickBase + ripRank.dmgTickPerCombo*cp

Check failure on line 108 in sim/druid/rip.go

View workflow job for this annotation

GitHub Actions / build-and-test

syntax error: unexpected newline, expected )
dot.Snapshot(target, baseDamage, isRollover)

Check failure on line 109 in sim/druid/rip.go

View workflow job for this annotation

GitHub Actions / build-and-test

syntax error: unexpected dot at end of statement
},
OnTick: func(sim *core.Simulation, target *core.Unit, dot *core.Dot) {
Expand Down

0 comments on commit 3758924

Please sign in to comment.