remove fab

CHANGELOG.md

@@ -2,6 +2,13 @@
 
 ## Unreleased
 
+### Removed
+
+- The `fab` component was removed. It might have made sense to have it as a
+  separate component before components could be customized, but since the
+  semantics are the same as a regular button, you can just make one with
+  `build_button(name: :fab, base_class: "fab")` if you need it.
+
 ## [0.8.2] - 2024-07-28
 
 ### Fixed

demo/lib/demo_web/components/core_components.ex

@@ -23,7 +23,6 @@ defmodule DemoWeb.CoreComponents do
   build_datetime()
   build_disclosure_button()
   build_drawer()
-  build_fab()
   build_fallback()
   build_field()
   build_field_group()

lib/doggo/components.ex

@@ -41,7 +41,6 @@ defmodule Doggo.Components do
         build_datetime()
         build_disclosure_button()
         build_drawer()
-        build_fab()
         build_fallback()
         build_field_group()
         build_frame()
@@ -147,7 +146,6 @@ defmodule Doggo.Components do
   component(:datetime)
   component(:disclosure_button)
   component(:drawer)
-  component(:fab)
   component(:fallback)
   component(:field)
   component(:field_group)

lib/doggo/components/button.ex

@@ -17,8 +17,7 @@ defmodule Doggo.Components.Button do
     current page and want to style the link like a button, use `button_link/1`
     instead.
 
-    See also `button_link/1`, `toggle_button/1`, `disclosure_button/1`, and
-    `fab/1`.
+    See also `button_link/1`, `toggle_button/1`, and `disclosure_button/1`.
     """
   end
 

test/doggo/components_test.exs

@@ -36,7 +36,6 @@ defmodule Doggo.ComponentsTest do
     build_datetime()
     build_disclosure_button()
     build_drawer()
-    build_fab()
     build_fallback()
     build_field(gettext_module: Doggo.Gettext)
     build_field_group()
@@ -2268,61 +2267,6 @@ defmodule Doggo.ComponentsTest do
     end
   end
 
-  describe "fab/1" do
-    test "default" do
-      assigns = %{}
-
-      html =
-        parse_heex(~H"""
-        <TestComponents.fab label="Add toy">add-icon</TestComponents.fab>
-        """)
-
-      button = find_one(html, "button:root")
-      assert attribute(button, "type") == "button"
-      assert attribute(button, "class") == "fab is-primary is-normal is-circle"
-      assert attribute(button, "aria-label") == "Add toy"
-      assert text(button) == "add-icon"
-    end
-
-    test "disabled" do
-      assigns = %{}
-
-      html =
-        parse_heex(~H"""
-        <TestComponents.fab label="Add toy" disabled>add-icon</TestComponents.fab>
-        """)
-
-      assert attribute(html, "button:root", "disabled") == "disabled"
-    end
-
-    test "with variant" do
-      assigns = %{}
-
-      html =
-        parse_heex(~H"""
-        <TestComponents.fab label="Add toy" variant="success">
-          add-icon
-        </TestComponents.fab>
-        """)
-
-      assert attribute(html, "button:root", "class") ==
-               "fab is-success is-normal is-circle"
-    end
-
-    test "with global attribute" do
-      assigns = %{}
-
-      html =
-        parse_heex(~H"""
-        <TestComponents.fab label="Add toy" phx-click="add">
-          add-icon
-        </TestComponents.fab>
-        """)
-
-      assert attribute(html, "button:root", "phx-click") == "add"
-    end
-  end
-
   describe "icon/1" do
     test "default" do
       assigns = %{}

test/doggo/storybook_test.exs

@@ -47,7 +47,6 @@ defmodule Doggo.StorybookTest do
     )
 
     build_drawer(modifiers: [variant: [values: [nil, "yes"], default: nil]])
-    build_fab(modifiers: [variant: [values: [nil, "yes"], default: nil]])
     build_fallback(modifiers: [variant: [values: [nil, "yes"], default: nil]])
     build_field()