Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve field component #399

Merged
merged 17 commits into from
Nov 19, 2024
Merged

improve field component #399

merged 17 commits into from
Nov 19, 2024

Conversation

woylie
Copy link
Owner

@woylie woylie commented Nov 18, 2024

resolves #318

@coveralls
Copy link

coveralls commented Nov 18, 2024

Pull Request Test Coverage Report for Build 2ceb5f7245bc631ce5ff0de768cb2deb3a254f24-PR-399

Details

  • 97 of 109 (88.99%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 81.579%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/doggo/components/field.ex 97 109 88.99%
Totals Coverage Status
Change from base Build cce0094972636e539e4b0b04eab96904e70db040: 0.6%
Covered Lines: 1674
Relevant Lines: 2052

💛 - Coveralls

@woylie woylie force-pushed the improve-field-component branch 2 times, most recently from e02f0ff to a67390a Compare November 18, 2024 23:34
@woylie woylie marked this pull request as ready for review November 19, 2024 01:06
@woylie woylie force-pushed the improve-field-component branch from a67390a to f669a88 Compare November 19, 2024 01:36
@woylie woylie enabled auto-merge November 19, 2024 01:47
@woylie woylie merged commit 49e74aa into main Nov 19, 2024
10 checks passed
@woylie woylie deleted the improve-field-component branch November 19, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve required mark for labels
2 participants