Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nest adapter opts #379

Merged
merged 2 commits into from
Jul 16, 2023
Merged

nest adapter opts #379

merged 2 commits into from
Jul 16, 2023

Conversation

woylie
Copy link
Owner

@woylie woylie commented Jul 16, 2023

  • move ecto-specific schema options to adapter
  • move ecto-specific backend options to adapter

relates to #238

@woylie woylie enabled auto-merge July 16, 2023 02:33
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Patch coverage: 95.83% and project coverage change: +0.06 🎉

Comparison is base (bc73df5) 87.99% compared to head (f3c6655) 88.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
+ Coverage   87.99%   88.05%   +0.06%     
==========================================
  Files          15       15              
  Lines         883      896      +13     
==========================================
+ Hits          777      789      +12     
- Misses        106      107       +1     
Impacted Files Coverage Δ
lib/flop/nimble_schemas.ex 71.42% <66.66%> (-8.58%) ⬇️
lib/flop.ex 94.68% <100.00%> (+0.07%) ⬆️
lib/flop/adapter/ecto.ex 97.95% <100.00%> (+0.13%) ⬆️
lib/flop/schema.ex 95.38% <100.00%> (+0.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@woylie woylie merged commit 4f064d5 into main Jul 16, 2023
@woylie woylie deleted the nest-adapter-opts branch July 16, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant