Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapter cursor dynamic #386

Merged
merged 5 commits into from
Jul 17, 2023
Merged

adapter cursor dynamic #386

merged 5 commits into from
Jul 17, 2023

Conversation

woylie
Copy link
Owner

@woylie woylie commented Jul 17, 2023

relates to #238

  • handle cursor_dynamic in adapter
  • remove cursor_dynamic function from Flop.Schema
  • update changelog
  • update ex_doc to 0.30.3
  • pass prepared cursor fields to adapter

@woylie woylie force-pushed the adapter-cursor-dynamic branch from 0866d1c to 406c2b0 Compare July 17, 2023 00:47
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 86.95% and project coverage change: -0.28 ⚠️

Comparison is base (202b1b0) 87.54% compared to head (406c2b0) 87.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
- Coverage   87.54%   87.26%   -0.28%     
==========================================
  Files          15       15              
  Lines         867      864       -3     
==========================================
- Hits          759      754       -5     
- Misses        108      110       +2     
Impacted Files Coverage Δ
lib/flop/schema.ex 95.83% <ø> (-0.56%) ⬇️
lib/flop/adapter/ecto.ex 92.00% <80.00%> (-2.67%) ⬇️
lib/flop.ex 94.84% <100.00%> (+0.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@woylie woylie merged commit d316fbe into main Jul 17, 2023
@woylie woylie deleted the adapter-cursor-dynamic branch July 17, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant