PHP deprecation error in WP_Image_Editor crop (`Implicit conversion from float) #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the PHP deprecated errors (like
Implicit conversion from float 1112.7466666666667 to int loses precision) inWP_Image_Editor_Imagick/WP_Image_Editorcropmethod.While
cropexpects integers, integers are not always passed to it.So the goal is to cast the params to cast
(int)before passing them to the method.Other usage of
cropalready haveintparams so only 2 occurrences were fixed.Tested on:
How to reproduce the error:
Implicit conversion from floatin the debug logTrac ticket:
https://core.trac.wordpress.org/ticket/59782