MERL-1270: Do not rewrite links in the post editor #1625

mindctrl · 2023-10-27T14:29:23Z

Tasks

If a code change, I have written testing instructions that the whole team & outside contributors can understand.
I have written and included a comprehensive changeset to properly document the changes I've made.
phpunit tests added

Description

When Faust’s “Enable Post and Category URL rewrites” is enabled, this has been causing URLs to be rewritten in the editor to contain the front-end URL instead of the WP URL, which causes them to be saved to the database this way.

Related: the guid value for the post is also saved with the Faust front-end URL. This should also be saved with the WP domain.

Ideally the WP URLs are saved to the database, so that:

The content is consistent
Our rewrite logic can properly target all desired URLs

Steps to Reproduce

Install and activate the Faust WP plugin
Add a front-end URL to the Faust settings. Leave “Enable Post and Category URL rewrites” enabled (which is the default)
Create a new post. Add a text link to another post. Note the front-end URL shows in the search results. Save the post.
Note the front-end URL was saved in post_content and guid instead of the WP URL.

Expected Behavior

The WP URL is saved to the database, so that the content is consistent and matches the domain/URL where it actually lives.

Testing

Check out this branch
Create a new post, follow the steps above.
Note the links use the WP domain and are saved in post_content and guid.
Try to break it! Look for flaws in the logic.

Documentation Changes

Dependant PRs

When Faust’s “Enable Post and Category URL rewrites” is enabled, this has been causing URLs to be rewritten in the editor to contain the front-end URL instead of the WP URL, which causes them to be saved to the database this way. Instead, we want the WP URL saved to the database.

changeset-bot · 2023-10-27T14:29:27Z

🦋 Changeset detected

Latest commit: 14d8384

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@faustwp/wordpress-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-10-27T14:33:47Z

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

plugins/faustwp/includes/replacement/callbacks.php

Confirms links are not rewritten on post-new.php pages when $_POST is empty. Also confirms Ajax requests to generate sample permalinks are not rewritten. These checks prevent the incorrect guid from being written to the database. Confirms `wp-link-ajax` Ajax requests are not rewritten. This is used by the Classic Editor when linking content. chore: update `enable_rewrites` values in tests to be `1` instead of `true`, for consistency.

plugins/faustwp/includes/replacement/callbacks.php

theodesp · 2023-11-02T15:11:10Z

I can verify the before and after using a sample post:

Before
I create a post and link to another post. The contents of the database are:

After
I create a post and link to another post. The contents of the database are:

Querying using GraphQLin both cases return the rewrite rule:

theodesp · 2023-11-02T17:05:56Z

plugins/faustwp/includes/replacement/callbacks.php

@@ -200,13 +200,39 @@ function post_preview_link( $link, $post ) {
 * @return string URL used for the post.
 */


Since we are preventing storing the Headless url in the database I think we need to add the following filter in line 24 for the content_blocks plugin:

add_filter( 'wpgraphql_content_blocks_resolver_content', __NAMESPACE__ . '\\content_replacement');

This is to ensure that we trigger domain replacement when resolving the blocks using parse_blocks.

Without the above filter:

With the above filter:

Unless there is a better way... @josephfusco any hints?

blakewilson · 2023-11-02T18:34:39Z

Nice work on this @mindctrl! I was also able to confirm what @theodesp is seeing as the correct behavior.

Before:

After:

(Not approving however do the concerns @theodesp raised with the content blocks filter)

mindctrl · 2023-11-15T12:59:45Z

@theodesp @TeresaGobble I just brought this up to date with canary. Can you please take another look?

blakewilson

Working good 👍

Tested with links to other posts and images as well.

mindctrl commented Oct 27, 2023

View reviewed changes

plugins/faustwp/includes/replacement/callbacks.php Outdated Show resolved Hide resolved

mindctrl added 5 commits October 27, 2023 11:55

fix: don't rewrite links in wp-link-ajax ajax requests

9b28506

fix: do not rewrite links on permalink generation requests

f2f4249

Merge branch 'canary' into merl-1270_fix-persisted-links

592f6b6

add changeset

5ed2451

mindctrl marked this pull request as ready for review October 31, 2023 16:41

mindctrl requested a review from a team as a code owner October 31, 2023 16:41

theodesp reviewed Nov 1, 2023

View reviewed changes

plugins/faustwp/includes/replacement/callbacks.php Outdated Show resolved Hide resolved

mindctrl mentioned this pull request Nov 2, 2023

MERL-1228: Fix issue with rewriting links to front end #1624

Merged

3 tasks

theodesp reviewed Nov 2, 2023

View reviewed changes

refactor: extract conditional logic to functions

ca09f06

mindctrl requested review from theodesp and blakewilson November 14, 2023 12:15

Merge branch 'canary' into merl-1270_fix-persisted-links

14d8384

This comment was marked as outdated.

Sign in to view

matthewguywright approved these changes Nov 15, 2023

View reviewed changes

blakewilson approved these changes Nov 15, 2023

View reviewed changes

mindctrl merged commit 75f5c80 into canary Nov 15, 2023
18 checks passed

mindctrl deleted the merl-1270_fix-persisted-links branch November 15, 2023 16:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MERL-1270: Do not rewrite links in the post editor #1625

MERL-1270: Do not rewrite links in the post editor #1625

mindctrl commented Oct 27, 2023 •

edited

Loading

changeset-bot bot commented Oct 27, 2023 •

edited

Loading

github-actions bot commented Oct 27, 2023 •

edited

Loading

theodesp commented Nov 2, 2023 •

edited

Loading

theodesp Nov 2, 2023 •

edited

Loading

blakewilson commented Nov 2, 2023

mindctrl commented Nov 15, 2023

This comment was marked as outdated.

blakewilson left a comment

		@@ -200,13 +200,39 @@ function post_preview_link( $link, $post ) {
		* @return string URL used for the post.
		*/

MERL-1270: Do not rewrite links in the post editor #1625

MERL-1270: Do not rewrite links in the post editor #1625

Conversation

mindctrl commented Oct 27, 2023 • edited Loading

Tasks

Description

Steps to Reproduce

Expected Behavior

Testing

Documentation Changes

Dependant PRs

changeset-bot bot commented Oct 27, 2023 • edited Loading

🦋 Changeset detected

github-actions bot commented Oct 27, 2023 • edited Loading

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

theodesp commented Nov 2, 2023 • edited Loading

theodesp Nov 2, 2023 • edited Loading

Choose a reason for hiding this comment

blakewilson commented Nov 2, 2023

mindctrl commented Nov 15, 2023

This comment was marked as outdated.

blakewilson left a comment

Choose a reason for hiding this comment

mindctrl commented Oct 27, 2023 •

edited

Loading

changeset-bot bot commented Oct 27, 2023 •

edited

Loading

github-actions bot commented Oct 27, 2023 •

edited

Loading

theodesp commented Nov 2, 2023 •

edited

Loading

theodesp Nov 2, 2023 •

edited

Loading