Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faust deprecation notices #1733

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Faust deprecation notices #1733

merged 4 commits into from
Jan 16, 2024

Conversation

blakewilson
Copy link
Contributor

@blakewilson blakewilson commented Jan 16, 2024

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

Adds deprecation notices to @faustjs/core, @faustjs/react, and @faustjs/next legacy packages. These can be observed here:

This PR also makes the legacy.faustjs.org banner more clean that Faust.js (GQty) has been deprecated and when support will end. This can be tested and observed by checking out this branch, cd internal/legacy.faustjs.org, npm install, then npm run dev

Once these changes have been merged and a new release is cut, we'll finally want to deprecate these three packages within NPM: https://docs.npmjs.com/cli/v8/commands/npm-deprecate

This makes it clear from the NPM website as well as CLI that a deprecated package is being installed.

Related Issue(s):

Testing

Screenshots

Documentation Changes

Dependant PRs

@blakewilson blakewilson requested a review from a team as a code owner January 16, 2024 19:17
Copy link

changeset-bot bot commented Jan 16, 2024

🦋 Changeset detected

Latest commit: cde880b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@faustjs/react Patch
@faustjs/core Patch
@faustjs/next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@blakewilson blakewilson merged commit 6b71e32 into canary Jan 16, 2024
19 checks passed
@blakewilson blakewilson deleted the faust-deprecation-notices branch January 16, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants