-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): #1966 Migrates glob-promise
dependency to Promise support…
#1967
Conversation
… supported `glob` package [!IMPORTANT] Glob has native Promise support as of v9.0.0, please use it directly. I will not issue a deprecation notice on this package, because I can't deal with the volume of angry tickets that will follow.
Currently, we do not support the creation of preview deployments based on changes coming from forked repositories. |
🦋 Changeset detectedLatest commit: 9fc2596 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hey @diegoavalon. Can you add |
…ly removes unneeded glob-promise dependency from @faustwp/cli package
hi @theodesp , |
@diegoavalon Could you also create a Changeset as well please? The instructions are mentioned in the changeset-bot
|
…ing changeset version manually
… running changeset version manually
Hi @theodesp , my apologies, I see what I did wrong. After creating the changeset for this change I manually executed |
Hey @diegoavalon thank you. This is the changeset for another PR and it should be part of the folder as well. |
Hey @diegoavalon . This PR that we merged yesterday contains this update so we can close this now. Thanks. |
Currently, we do not support the creation of preview deployments based on changes coming from forked repositories. |
!IMPORTANT
Glob has native Promise support as of v9.0.0, please use it directly. I will not issue a deprecation notice on this package, because I can't deal with the volume of angry tickets that will follow.