Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): #1966 Migrates glob-promise dependency to Promise support… #1967

Closed
wants to merge 7 commits into from

Conversation

diegoavalon
Copy link

!IMPORTANT

Glob has native Promise support as of v9.0.0, please use it directly. I will not issue a deprecation notice on this package, because I can't deal with the volume of angry tickets that will follow.

… supported `glob` package

[!IMPORTANT]
Glob has native Promise support as of v9.0.0, please use it directly. I will not issue a deprecation notice on this package, because I can't deal with the volume of angry tickets that will follow.
@diegoavalon diegoavalon requested a review from a team as a code owner October 9, 2024 01:41

Currently, we do not support the creation of preview deployments based on changes coming from forked repositories.
Learn more about preview environments in our documentation.

Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: 9fc2596

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@faustwp/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@theodesp
Copy link
Member

theodesp commented Oct 9, 2024

Hey @diegoavalon. Can you add glob-promise in package.json dev dependency as well please?

…ly removes unneeded glob-promise dependency from @faustwp/cli package
@diegoavalon
Copy link
Author

hi @theodesp , glob-promise isn't being used in this package anymore and has been removed.

@theodesp
Copy link
Member

@diegoavalon Could you also create a Changeset as well please? The instructions are mentioned in the changeset-bot

npm run changeset

@diegoavalon
Copy link
Author

Hi @theodesp , my apologies, I see what I did wrong. After creating the changeset for this change I manually executed npm changeset version locally which bumped the affected package versions and deleted the generated changeset.md file. Instead, this should have been a CI step. Hopefully, this PR is now as expected. Can you kindly validate?

@theodesp
Copy link
Member

Hey @diegoavalon thank you.
Could you restore this file please?
https://github.com/wpengine/faustjs/pull/1967/files#diff-acbd6f841eb36512210b996294dcd4050a5febdb1fa023bb30c962f6c2707314

This is the changeset for another PR and it should be part of the folder as well.

@diegoavalon
Copy link
Author

hi @theodesp , can you kindly review this new PR cut from a clean branch and commit history of these changes?
PR #1966

@theodesp
Copy link
Member

theodesp commented Nov 5, 2024

Hey @diegoavalon . This PR that we merged yesterday contains this update so we can close this now. Thanks.

@theodesp theodesp closed this Nov 5, 2024

Currently, we do not support the creation of preview deployments based on changes coming from forked repositories.
Learn more about preview environments in our documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants