Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate experimental app router package #1976

Closed
wants to merge 2 commits into from

Conversation

theodesp
Copy link
Member

@theodesp theodesp commented Oct 21, 2024

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

  • Separate experimental app router package on its own folder
  • Remove app-router example project from the workspace so the dependencies declared in each example should be isolated to that example and not included when installing dependencies for the packages.
  • Update app-router example project dependencies.

Related Issue(s):

#1952

Testing

Screenshots

Documentation Changes

Dependant PRs

@theodesp theodesp requested a review from a team as a code owner October 21, 2024 15:41
Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: e1658db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@faustwp/app-router-example" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Copy link
Contributor

github-actions bot commented Oct 21, 2024

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@theodesp theodesp force-pushed the feat/separate-experimental-router branch from 0176266 to 2997a94 Compare October 21, 2024 16:22
@theodesp theodesp closed this Nov 5, 2024
@theodesp theodesp deleted the feat/separate-experimental-router branch November 5, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant