Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate legacy example projects #1977

Merged
merged 10 commits into from
Nov 4, 2024

Conversation

theodesp
Copy link
Member

@theodesp theodesp commented Oct 22, 2024

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

  • Separate examples out of workspaces: app-router, block-support and getting-started.
  • Fix GH pipeline for getting-started example using e2e-test-plugin.yml

Related Issue(s):

Testing

Screenshots

Documentation Changes

Dependant PRs

@theodesp theodesp requested a review from a team as a code owner October 22, 2024 12:15
Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: defa0a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@faustwp/experimental-app-router Minor
@faustwp/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 22, 2024

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 260.06 KB (🟡 +9.56 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 269 B 260.33 KB 74.38% (🟢 -0.01%)
/[...wordpressNode] 282 B 260.34 KB 74.38% (+/- <0.01%)
/_error 180 B 260.24 KB 74.35% (+/- <0.01%)
/example 829 B 260.87 KB 74.54% (🟢 -0.01%)
/preview 261 B 260.32 KB 74.38% (🟢 -0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@theodesp theodesp force-pushed the feat/separate-legacy-examples branch from e8d0cb8 to 9cd7fe8 Compare October 22, 2024 20:24
@theodesp theodesp force-pushed the feat/separate-legacy-examples branch from c0b91a2 to 5116380 Compare October 31, 2024 14:41
Copy link
Member

@josephfusco josephfusco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After copying .env.local.example to .env.local in the example project, I was able to see the example site spin up without issues. 🙌🏼

@josephfusco josephfusco added the scope: security Securing against vulnerabilities and threats label Nov 4, 2024
@josephfusco josephfusco merged commit e22b87d into canary Nov 4, 2024
18 checks passed
@josephfusco josephfusco deleted the feat/separate-legacy-examples branch November 4, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: security Securing against vulnerabilities and threats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants