2024 updates #24
Closed
2024 updates #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
guineawheek
commented
Dec 17, 2023
guineawheek
commented
- Bump the macOS target to 12 (like the rest of wpilib)
- Change the CI action to not depend on the name of the repository
- Add Javadocs to VendorJNI.java for Java 17 compliance
- (The roboRIO tests all fail, so CI is still broken....sigh)
guineawheek
changed the title
|
You need to update to the 2024 docker image, to get the 2024 compiler. |
|
I think this duplicated #21, which I just merged. If it’s still an issue, please comment. |
|
Looks like the remaining differences in this PR are upgrading the macOS runner and deployment target to 12 and adding some JNI docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.