Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cVszArchive.cls to add Unicode Support to "Addfiles" #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Hobbybyte
Copy link

Added Unicode Support for Creating Archives
Changing FindFirstFileA to FindFirstFileW in Function AddFiles

Thanks for creating and sharing such a great vb code

@wqweto
Copy link
Owner

wqweto commented Apr 19, 2023

Current WIN32_FIND_DATA declaration uses String members which get ANSI<->Unicode transcoded which is a problem for Unicode API functions (like FindFirstFileW) which do not need any transcoding to happen at callsite.

To prevent this auto-transcoding the last parameter of FindFirstFile API declare should become ByVal lpFindFileData As Long and callsite should use VarPtr(uData) for actual argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants