Respect the order in which queues/patterns are defined #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of returning matched queues sorted alphabetically, pre-sort all queues and keep the order in which patterns are defined.
|
@jfahrer My team was looking to fix this, so I merged this into our fork (https://github.com/BustedTees/resque-dynamic-queues). Think this repo is dead, given that a PR I opened fixing wildcards 4 years ago is still just sitting untouched. :) |
|
Yes, sorry, I haven't touched resque in a long time. Happy to hand over maintenance to contributors if you'd like to be able to push gems, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default Resque behavior is to respect the order in which queues are defined. Currently,
resque-dynamic-queuesreturns all matched queues sorted alphabetically. This might lead to confusing results.Example
Existing queues:
Resque::Worker.new(a_*_high, a_*_medium, a_*_low").queues["a_ext_high", "a_ext_low", "a_ext_medium", "a_int_high", "a_int_low", "a_int_medium"]["a_ext_high", "a_int_high", "a_ext_medium", "a_int_medium", "a_ext_low", "a_int_low"]Instead of returning matched queues sorted alphabetically, pre-sort all queues and keep the order in which patterns were defined.