Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/overture building #47

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Feature/overture building #47

merged 5 commits into from
Jul 2, 2024

Conversation

weiqi-tori
Copy link
Member

Description: Add layer for https://docs.overturemaps.org/schema/reference/buildings/building/
JIRA ticket is https://gfw.atlassian.net/browse/CIF-184
Test by running pytest layers.py::test_overture_buildings

@weiqi-tori weiqi-tori requested a review from chrowe June 17, 2024 07:55
chrowe
chrowe approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@chrowe chrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed.
Added example notebook.
Was able to download a 300 km2 area in 2.5 minutes.

It is way faster to write out a geoparquet file. Like a few seconds vs over a minute for geojson. Maybe we want to try downloading as a geoparquet at some point.

@chrowe chrowe merged commit 6e3eb42 into main Jul 2, 2024
1 check failed
@chrowe chrowe deleted the feature/overture_building branch July 2, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrowe chrowe chrowe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiqi-tori @chrowe