Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cif 200 layers ndvi #65

Merged
merged 13 commits into from
Aug 27, 2024
Merged

Cif 200 layers ndvi #65

merged 13 commits into from
Aug 27, 2024

Conversation

kcartier-wri
Copy link
Contributor

Did you read the Contributor Guide?

Yes

Is this PR related to a JIRA ticket?

https://gfw.atlassian.net/browse/CIF-200

What changes were proposed in this PR?

Added NDVI layer.

How was this patch tested?

locally

Did this PR include necessary documentation updates?

No

@kcartier-wri
Copy link
Contributor Author

@jterry64 @chrowe - Could you both review the code for NDVI and the associated changes for testing? I'll then ask Ted Wong to review relative to his Jupyter notebook. Thanks

@kcartier-wri kcartier-wri marked this pull request as ready for review August 26, 2024 17:47
jterry64
jterry64 requested changes Aug 26, 2024
View reviewed changes
Copy link
Member

@jterry64 jterry64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for most part, just had some uncertainty about the map rendering part, let's all talk about in the check in

city_metrix/layers/ndvi_sentinel2_gee.py Outdated Show resolved Hide resolved
city_metrix/layers/ndvi_sentinel2_gee.py Outdated Show resolved Hide resolved
@kcartier-wri kcartier-wri requested a review from jterry64 August 27, 2024 21:12
@kcartier-wri kcartier-wri merged commit 5b28121 into main Aug 27, 2024
1 check passed
@kcartier-wri kcartier-wri deleted the CIF-200-LAYERS-NDVI branch August 27, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedw0ng tedw0ng tedw0ng left review comments

@jterry64 jterry64 jterry64 approved these changes

@chrowe chrowe Awaiting requested review from chrowe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kcartier-wri @jterry64 @tedw0ng