FLAG-900: Undefined year causing an error in the TCL due to Fires widget in protected and some custom area dashboards #4681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en calling the OTF function
…s are the source of truth when doing calculations
wri7tno
reviewed
Sep 1, 2023
| @@ -19,7 +19,7 @@ const SQL_QUERIES = { | |||
| lossFires: | |||
| 'SELECT {select_location}, umd_tree_cover_loss__year, SUM(umd_tree_cover_loss__ha) AS umd_tree_cover_loss__ha, SUM(umd_tree_cover_loss_from_fires__ha) AS "umd_tree_cover_loss_from_fires__ha" FROM data {WHERE} GROUP BY umd_tree_cover_loss__year, {location} ORDER BY umd_tree_cover_loss__year, {location}', | |||
| lossFiresOTF: | |||
| 'SELECT umd_tree_cover_loss__year, sum(umd_tree_cover_loss__ha), sum(umd_tree_cover_loss_from_fires__ha) FROM data WHERE umd_tree_cover_loss__year >= {startYear} AND umd_tree_cover_loss__year <= {endYear} AND umd_tree_cover_density_2000__threshold >= 30 GROUP BY umd_tree_cover_loss__year', | |||
There was a problem hiding this comment.
huh, wonder why did we have a hardcoded value here 🤔
There was a problem hiding this comment.
Most likely an oversight that evaded Code Review and QA. I've added my thoughts as to how it may happened to the JIRA task. I would guess that during the development of a new widget, the example SQL query we get from the data team was used directly in order to build the widget, and then we missed the fact we need to do interpolation as well.
We had a similar issue before, concerning the {startYear} and {endYear} addressed here.
|
LGTM, tested 👍 |
wri7tno
approved these changes
Sep 1, 2023
SARodrigues
deleted the
FLAG-900-undefined-year-causing-an-error-in-the-tcl-due-to-fires-widget-in-protected-and-some-custom-area-dashboards
branch
SARodrigues
restored the
FLAG-900-undefined-year-causing-an-error-in-the-tcl-due-to-fires-widget-in-protected-and-some-custom-area-dashboards
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the issue where the fires widget breaks when it is set to do an OTF analysis, due to missing start and year years in the settings, causing the SQL query to be misconstructed.
Notes
It also includes a minor refactoring to the data processing in an attempt to prevent such mistakes by using the widgets' settings as the source of truth, and enables the "Years" setting that seems to have been missing for a while.
Testing
Test the links from the JIRA task (linked below) on this staging environment, verify that they now work.
Tracking
FLAG-900