[FLAG-943] Tropical Tree Cover analysis malfunctioning #4707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now when the user select a thresold on the ttc layer, tree cover density widget will ignore that and keep fetching using >=10% of thresold and the right table wri_tropical_tree_cover__decile
willian-viana
changed the title
- Improve readability - Add tree cover density validation to remove threshold paramater from layers - Split responsibilities to follow single-responsibility principle
willian-viana
force-pushed
the
hotfix/ttc-analysis-FLAG-943
branch
from
9f1e376 to
abc47eb
Compare
wri7tno
reviewed
Oct 17, 2023
wri7tno
reviewed
Oct 18, 2023
wri7tno
reviewed
Oct 18, 2023
wri7tno
approved these changes
Oct 18, 2023
wri7tno
reviewed
Oct 20, 2023
| @@ -0,0 +1,41 @@ | |||
| import { getWHEREQuery } from '../get-where-query'; | |||
|
|
|||
| describe('getWHEREQuery', () => { | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Tree Cover Density widget doesn't work correctly on Analysis when threshold is added as parameter.
This widget has its own threshold (>10 as default), but when a user selects Tropical Tree Cover layer and changes the threshold, a new parameter was added to the query, making the request fail.
We did a major refactor at the
getWHEREQueryto improve readability and add some new validations.Demo
Testing