[FLAG-965] Fix VIIRS dropdown #4721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid errors between viirs layers and wigets with the new options (high confidence) we added some validations to getWhereQuery method To the future, we will need to think a better solution
Now we can access layer options when the widget is render on the map
To avoid confidence__cat = 'h' to be added on the query, since we always fetch by all alerts
…rrors on the query
willian-viana
changed the title
wri7tno
approved these changes
Nov 7, 2023
|
LGTM tested |
… as a boolean To use this new parameter on the tile endpoint we need to use a boolean to high_confidence_only So I removed the object and set again as a boolean
willian-viana
force-pushed
the
fix/viirs-dropdown-FLAG-965
branch
from
a8c029f to
547814d
Compare
willian-viana
force-pushed
the
fix/viirs-dropdown-FLAG-965
branch
from
547814d to
df9b223
Compare
willian-viana
force-pushed
the
fix/viirs-dropdown-FLAG-965
branch
from
df9b223 to
600739b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
After we launched the high/all confidence dropdown here, we noted that VIIRS analysis showed 0 for both custom and admin areas.
Demo
Notes
I had to add new validation on getWhereQuery method. We need to think a better solution to handle new layer features and the related widgets.
Testing