Fixes requested by client #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
luccasmmg
commented
Nov 15, 2023
luccasmmg
commented
- Changed all of these to be RTEs
- Added "type=button" to the RTE buttons so they dont end up triggering the submit in the form(Hope i didnt leave any out)
- Fixed the link modal width
- In the teams and topics form you can no longer set the topic/team you were editing as their own parent
- Now we only trigger the validation for technical notes if the visibility is set to public
- Added a "open-in" section that should populate that "Open in" dropdown in the dataset individual page
- Added the progress indicator in the form (the percentage) will only be able to be 100% sure it works once its deployed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.