Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ODP-160]: Dashboard functionality implementation #84

Merged
merged 26 commits into from
Nov 9, 2023
Merged

[ODP-160]: Dashboard functionality implementation #84

merged 26 commits into from
Nov 9, 2023

Conversation

steveoni
Copy link
Collaborator

@steveoni steveoni commented Nov 9, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: odp-160

What is the new behavior?

This pr adds search and pagination to pages and also ensure data are fetched from backend. also added test

Does this introduce a breaking change?

  • Yes
  • No

Other information

@steveoni steveoni requested a review from luccasmmg November 9, 2023 10:44
Copy link
Collaborator

@luccasmmg luccasmmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luccasmmg luccasmmg merged commit b05a613 into dev Nov 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants