Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TM-1171] fix role policy check #423

Draft
wants to merge 1 commit into
base: staging
Choose a base branch
from
Draft

[TM-1171] fix role policy check #423

wants to merge 1 commit into from

Conversation

pachonjcl
Copy link
Collaborator

@pachonjcl pachonjcl marked this pull request as ready for review August 21, 2024 17:59
@pachonjcl pachonjcl requested a review from roguenet August 21, 2024 18:00
roguenet
roguenet reviewed Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@roguenet roguenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use can('projects-manage') over hasRole. We should always prefer to check permissions over roles in the updated system, when possible.

roguenet
roguenet requested changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@roguenet roguenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, meant to request changes. Please use can->('projects-manage') instead.

@pachonjcl pachonjcl marked this pull request as draft September 9, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roguenet roguenet roguenet requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pachonjcl @roguenet