[TM-1531] add job connection #745
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
roguenet
reviewed
Dec 13, 2024
| return (delayedJobs != null && delayedJobs.length > 0) || hasLoadFailed || isLoading; | ||
| }; | ||
|
|
||
| const delayedJobsConnection: Connection<DelayedJobsConnection, DelayedJobsProps> = { |
There was a problem hiding this comment.
These props aren't used, no reason to include them.
| const delayedJobsLoadFailedSelector = (store: ApiDataStore, { uuid }: DelayedJobsProps) => { | ||
| const variables: DelayedJobsFindVariables = { | ||
| pathParams: { uuid } | ||
| }; |
There was a problem hiding this comment.
Since the API request doesn't use these path params, the load failed selector shouldn't either. The params to those two must always match for this feature to function.
| selector: selectorCache( | ||
| props => props.uuid, | ||
| props => | ||
| createSelector( |
There was a problem hiding this comment.
Since there are no props, the selector cache isn't needed - it's only needed when there are props to differentiate different selectors. The selector here can just receive createSelector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the connection to pull the list of jobs