numpy 2.0 compatability #1185
Merged
numpy 2.0 compatability #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still need to deal with trapz --> trapezoid (not backward compatible) be sure to change docs as well
for more information, see https://pre-commit.ci
|
everything looks ready on our end; just waiting on an upstream fix (untzag/tidy_headers#20) to get this through |
ddkohler
requested review from
untzag,
ksunden,
darienmorrow and
kameyer226
as code owners
increment tidy_headers so there is no numpy 2.0 issue
kameyer226
reviewed
Oct 23, 2024
kameyer226
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the transition to support the new API
https://numpy.org/doc/stable/numpy_2_0_migration_guide.html
Changes
Checklist