Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing claims for federated users for jwt token issuers #2613

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sandushi
Copy link
Contributor

Purpose

  • Fix the issue of missing claims for federated users for jwt token issuers.
  • To get the tokenID from the access token, we need to pass the jti of the jwt tokens.
  • From this PR, the changes are done for the jwt token to extract the jti value and pass it for the getTokenIdByAccessToken to - get the token id.

Related issue

wso2/product-is#21387

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11623432184

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.81%. Comparing base (7acf35a) to head (9b1c5ec).
Report is 72 commits behind head on master.

Files with missing lines Patch % Lines
.../identity/oauth/cache/AuthorizationGrantCache.java 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2613      +/-   ##
============================================
- Coverage     54.95%   53.81%   -1.14%     
- Complexity     8259     8459     +200     
============================================
  Files           632      632              
  Lines         47577    50233    +2656     
  Branches       7567     8963    +1396     
============================================
+ Hits          26144    27032     +888     
- Misses        17606    19252    +1646     
- Partials       3827     3949     +122     
Flag Coverage Δ
unit 38.61% <55.55%> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11623432184
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11657748364

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11657748364
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11934561217

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11934561217
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11948007129

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11948007129
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11948007129

@Thumimku
Copy link
Contributor

Hi @sandushi,

⚠️ Notice: This PR has been open for a while. To keep the repository clean and up-to-date, this PR will be closed within the next two weeks if there is no further activity.

Please take one of the following actions:

  • Merge the PR if it is ready.
  • Close the PR if it is no longer relevant.
  • Leave a comment explaining why it should remain open and provide an update on its progress.

Your prompt attention to this matter is greatly appreciated. Thank you for your understanding and collaboration! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants