Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clean Up] Clean Webfinger Code #2624

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Thumimku
Copy link
Contributor

Proposed changes in this pull request

  1. Log is a static final variable, so it should be "LOG" not "log".
  2. Clean some unwanted lines.
  3. Checking for debug enabled is redundent, but improve performance if the logging message contains computations. But if there is no computations, no concatinations then checking debug enabled affect the performance. Hence I selectively remove debug enabled checks if the message is simple.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11776547371

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 22.72727% with 17 lines in your changes missing coverage. Please review.

Project coverage is 54.48%. Comparing base (69881de) to head (9736322).
Report is 38 commits behind head on master.

Files with missing lines Patch % Lines
.../identity/webfinger/DefaultWebFingerProcessor.java 20.00% 7 Missing and 1 partial ⚠️
.../webfinger/internal/WebFingerServiceComponent.java 0.00% 8 Missing ⚠️
...n/identity/webfinger/servlet/WebFingerServlet.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2624      +/-   ##
============================================
- Coverage     55.24%   54.48%   -0.76%     
- Complexity     8260     8336      +76     
============================================
  Files           632      632              
  Lines         47943    49518    +1575     
  Branches       7867     8256     +389     
============================================
+ Hits          26484    26979     +495     
- Misses        17630    18622     +992     
- Partials       3829     3917      +88     
Flag Coverage Δ
unit 38.64% <22.72%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11776547371
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11789838759

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11789838759
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11789838759

@Thumimku
Copy link
Contributor Author

Hi @Thumimku,

⚠️ Notice: This PR has been open for a while. To keep the repository clean and up-to-date, this PR will be closed within the next two weeks if there is no further activity.

Please take one of the following actions:

  • Merge the PR if it is ready.
  • Close the PR if it is no longer relevant.
  • Leave a comment explaining why it should remain open and provide an update on its progress.

Your prompt attention to this matter is greatly appreciated. Thank you for your understanding and collaboration! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants