Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat the ID token signature validation failure as client error instead of generic error which will be logged as server error later #2628

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sadilchamishka
Copy link
Contributor

Proposed changes in this pull request

In the OIDC logout request, The ID token signature validation failure is not required to be handled as server error and log the error. It should be a client error as the id token is sent by the client apps, along with OIDC logout request.

The failure should have been handled by this exception block [1], but it is being handled from this exception block[2].

[1] - https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/master/components/org.wso2.carbon.identity.oidc.session/src/main/java/org/wso2/carbon/identity/oidc/session/servlet/OIDCLogoutServlet.java#L244~L251
[2] - https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/master/components/org.wso2.carbon.identity.oidc.session/src/main/java/org/wso2/carbon/identity/oidc/session/servlet/OIDCLogoutServlet.java#L252~L255

…ic error which will be logged as server error later
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.73%. Comparing base (1eb13c1) to head (d25dd76).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2628   +/-   ##
=========================================
  Coverage     55.73%   55.73%           
+ Complexity     8234     8183   -51     
=========================================
  Files           632      632           
  Lines         47478    47478           
  Branches       8385     8385           
=========================================
  Hits          26463    26463           
  Misses        17228    17228           
  Partials       3787     3787           
Flag Coverage Δ
unit 38.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11897632050

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11897632050
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11897632050

@sadilchamishka sadilchamishka changed the title Treat the ID token signature failure as client error instead of generic error which will be logged as server error later Treat the ID token signature validation failure as client error instead of generic error which will be logged as server error later Nov 19, 2024
@sadilchamishka sadilchamishka marked this pull request as draft November 26, 2024 02:04
@Thumimku
Copy link
Contributor

Hi @sadilchamishka,

⚠️ Notice: This PR has been open for a while. To keep the repository clean and up-to-date, this PR will be closed within the next two weeks if there is no further activity.

Please take one of the following actions:

  • Merge the PR if it is ready.
  • Close the PR if it is no longer relevant.
  • Leave a comment explaining why it should remain open and provide an update on its progress.

Your prompt attention to this matter is greatly appreciated. Thank you for your understanding and collaboration! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants