Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary DB queries when revoking tokens #2640

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SujanSanjula96
Copy link
Contributor

Proposed changes in this pull request

From this PR,

  • Fixed unnecessary DB queries due to invoking getRoles method.
  • Removed the usage of getting associated applications since it is unnecessary.
  • Refactored unnecessary iterations related to associated applications.

Issue - wso2/product-is#21496

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 56.41%. Comparing base (654bc26) to head (a82357a).

Files with missing lines Patch % Lines
...java/org/wso2/carbon/identity/oauth/OAuthUtil.java 0.00% 24 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2640      +/-   ##
============================================
- Coverage     56.43%   56.41%   -0.02%     
+ Complexity     8188     8177      -11     
============================================
  Files           632      632              
  Lines         46323    46316       -7     
  Branches       8245     8242       -3     
============================================
- Hits          26141    26130      -11     
- Misses        16469    16470       +1     
- Partials       3713     3716       +3     
Flag Coverage Δ
unit 38.69% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant