-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for managing custom federated authenticators. #6105
base: master
Are you sure you want to change the base?
Add support for managing custom federated authenticators. #6105
Conversation
6ce13a6
to
e887bdf
Compare
e887bdf
to
35805c7
Compare
a6d7a29
to
16268ae
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6105 +/- ##
============================================
- Coverage 41.13% 40.20% -0.93%
- Complexity 14752 14823 +71
============================================
Files 1776 1758 -18
Lines 118407 118206 -201
Branches 19691 20827 +1136
============================================
- Hits 48701 47520 -1181
- Misses 62383 63473 +1090
+ Partials 7323 7213 -110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c34802d
to
855a182
Compare
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 suggestion.
Files not reviewed (2)
- components/idp-mgt/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/IdPManagementDAO.java: Evaluated as low risk
- components/idp-mgt/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/util/IdPManagementConstants.java: Evaluated as low risk
Comments skipped due to low confidence (1)
components/idp-mgt/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/util/AuthenticatorEndpointConfigurationManager.java:166
- The method should accept
AuthenticationType
as a parameter instead of hardcodingIDENTIFICATION
.
return new UserDefinedFederatedAuthenticatorConfig(AuthenticatorPropertyConstants.AuthenticationType.IDENTIFICATION);
...gt/src/main/java/org/wso2/carbon/idp/mgt/util/AuthenticatorEndpointConfigurationManager.java
Outdated
Show resolved
Hide resolved
4f4026e
to
e282f69
Compare
e282f69
to
8f5db0d
Compare
ddc6235
to
5a06202
Compare
dd8eed1
to
6ec6eb9
Compare
6ec6eb9
to
ad64f90
Compare
10f347e
to
21fdb39
Compare
PR builder completed |
21fdb39
to
de21353
Compare
PR builder started |
PR builder started |
PR builder completed |
PR builder started |
PR builder completed |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11958767346
de21353
to
ba424b9
Compare
814c4fd
to
5def815
Compare
5def815
to
ec3d693
Compare
9000606
to
ba2a680
Compare
ba2a680
to
3d069a9
Compare
Quality Gate passedIssues Measures |
Issue:
With this PR, the IDP management service layer is enhanced to support custom federated authentication extensions.
The following changes are included:
API layer PR: