Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change exception thrown when realm not found for a given name and include error code in exception thrown. #3846

Open
wants to merge 3 commits into
base: 4.10.x
Choose a base branch
from
Open

Change exception thrown when realm not found for a given name and include error code in exception thrown. #3846

wants to merge 3 commits into from
+3 −1

Conversation

RushanNanayakkara
Copy link

@RushanNanayakkara RushanNanayakkara commented Feb 6, 2024 •
edited
Loading

Purpose

This PR changes the exception thrown at the AbstractUserStoreManager when a user store is not found for a given tenant domain name, to use ERROR_CODE_INVALID_DOMAIN_NAME constant and use an error code. This helps identify the thrown exception at a higher level.

Related Issue

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7803764660

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7803764660
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Feb 6, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7803764660

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7884298895

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7884298895
Status: failure

@RushanNanayakkara RushanNanayakkara mentioned this pull request Mar 8, 2024
Closed
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8277965419

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8277965419
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Mar 14, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/8277965419

@RushanNanayakkara @pamodaaw
Suggested style fix
35fc226 
Co-authored-by: Pamoda Wimalasiri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@pamodaaw pamodaaw pamodaaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RushanNanayakkara @jenkins-is-staging @pamodaaw