-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for expressions in endpoint definition attributes. #2238
base: master
Are you sure you want to change the base?
Add support for expressions in endpoint definition attributes. #2238
Conversation
…json representation change
…pend state properties change
…out state properties change
Please squash these commits to a single one |
...es/core/src/main/java/org/apache/synapse/config/xml/endpoints/EndpointDefinitionFactory.java
Outdated
Show resolved
Hide resolved
...es/core/src/main/java/org/apache/synapse/config/xml/endpoints/EndpointDefinitionFactory.java
Outdated
Show resolved
Hide resolved
...es/core/src/main/java/org/apache/synapse/config/xml/endpoints/EndpointDefinitionFactory.java
Outdated
Show resolved
Hide resolved
...es/core/src/main/java/org/apache/synapse/config/xml/endpoints/EndpointDefinitionFactory.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/synapse/endpoints/Endpoint.java
Outdated
Show resolved
Hide resolved
d = d.trim().substring(1, d.length() - 1); | ||
SynapseXPath xpath = new SynapseXPath(d); | ||
definition.setDynamicTimeoutExpression(xpath); | ||
if (isExpression(d)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this check? The ValueFactory will check wether it's an expression or not and resolve the value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated using ValueFactory.
Purpose
Consider the following HTTP endpoint definition. To handle this definition, expression support is required for endpoint attributes. Currently, only
timeout-duration
supports expressions, but the need for expression support in other attributes has occurred during the implementation of the HTTP connector.