Skip to content

Commit

Permalink
Issue 228 remove explicit dependency on java plugin (#229)
Browse files Browse the repository at this point in the history
issue #228 | Remove explicit dependency on Java plugin

It appears AEM Rules 1.5 caused an error when it was being uploaded to
the Marketplace. See:
https://community.sonarsource.com/t/new-release-aem-rules-1-5/61314/2

G Ann Campbell suggested that the `requirePlugins` metadata property
declaring a dependency on the Java plugin can be removed on the grounds
of Java analysis being an out-of-the-box feature.

Disable fail-fast strategy for builds across SonarQube versions so that all build even if one should fail, use latest images on top of specific versions
  • Loading branch information
tomasz-niedzwiedz-wttech authored Apr 8, 2022
1 parent 92a175f commit 96d9385
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .github/workflows/test-instalation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ jobs:
sonarqube-image:
- 'sonarqube:8.9-community'
- 'sonarqube:9.4-community'
- 'sonarqube:lts-community'
- 'sonarqube:latest'
fail-fast: false
steps:
# To use this repository's private action,
# you must check out the repository
Expand Down
1 change: 0 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,6 @@
</pluginSourcesUrl>
<pluginUrl>https://github.com/wttech/AEM-Rules-for-SonarQube</pluginUrl>
<skipDependenciesPackaging>false</skipDependenciesPackaging>
<requirePlugins>java:6.15</requirePlugins>
<sonarQubeMinVersion>8.9</sonarQubeMinVersion>
<sonarLintSupported>true</sonarLintSupported>
</configuration>
Expand Down

0 comments on commit 96d9385

Please sign in to comment.