Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SonarQube 10.x (Java 17 compatible) #243

Closed

Conversation

tomasz-strzelecki-vml
Copy link
Collaborator

No description provided.

@tomasz-strzelecki-vml tomasz-strzelecki-vml force-pushed the 10.x-version-migration branch 15 times, most recently from de82537 to a6bf08b Compare October 21, 2024 15:36
@macskay
Copy link

macskay commented Oct 22, 2024

Hi,
So glad you are working on this. We deactivated the plugin so far as it kept us from building our releases after upgrading to SonarQube 10.X. Can you give a rough estimate when this migration will be available just for planning purposes.

Thank you so much for looking into this

@tomasz-strzelecki-vml
Copy link
Collaborator Author

tomasz-strzelecki-vml commented Oct 22, 2024 via email

.github/actions/test-plugin-installation/action.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.cirrus.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
conf/webpack/webpack.config.prod.js Outdated Show resolved Hide resolved
@tomasz-strzelecki-vml tomasz-strzelecki-vml force-pushed the 10.x-version-migration branch 9 times, most recently from f643594 to 1966e63 Compare October 29, 2024 11:30
@tomasz-strzelecki-vml tomasz-strzelecki-vml changed the title 10.x version migration 10.x version migration (Java 17 support) Oct 29, 2024
@tomasz-strzelecki-vml tomasz-strzelecki-vml changed the title 10.x version migration (Java 17 support) 10.x version migration (Java 17 compatible) Oct 29, 2024
@tomasz-strzelecki-vml tomasz-strzelecki-vml changed the title 10.x version migration (Java 17 compatible) SonarQube 10.x version (Java 17 compatible) Oct 29, 2024
@tomasz-strzelecki-vml tomasz-strzelecki-vml changed the title SonarQube 10.x version (Java 17 compatible) SonarQube 10.x (Java 17 compatible) Oct 29, 2024
@tomasz-strzelecki-vml tomasz-strzelecki-vml changed the base branch from master to 9.9-version-migration October 29, 2024 14:45
@tomasz-strzelecki-vml tomasz-strzelecki-vml deleted the 10.x-version-migration branch October 29, 2024 15:47
@tomasz-strzelecki-vml tomasz-strzelecki-vml restored the 10.x-version-migration branch October 29, 2024 15:48
@tomasz-strzelecki-vml
Copy link
Collaborator Author

Hi @macskay. The version 1.7 will be released till the end of the week. This PR has been moved to #245.

@tomasz-strzelecki-vml
Copy link
Collaborator Author

@macskay, I would be extremely grateful for your feedback on the 1.7 plugin version. I'd like to release it as the latest version. You can find it here: https://github.com/wttech/AEM-Rules-for-SonarQube/releases/tag/v1.7

@macskay
Copy link

macskay commented Nov 13, 2024

Awesome, I was out of order with COVID the past couple of days. Will test it out and get backj to you as soon as I have news :)

@macskay
Copy link

macskay commented Nov 14, 2024

Unfortunately it did not work for us. We tried installing but the SonarQube Server restarts after throwing the following error:

2024.11.14 08:32:31 ERROR web[][o.s.s.p.Platform] Background initialization failed. Stopping SonarQube org.sonar.server.es.ElasticsearchException: Fail to execute es requestES refresh request on indices 'rules' at org.sonar.server.es.EsClient.execute(EsClient.java:336) at org.sonar.server.es.EsClient.refresh(EsClient.java:159) at org.sonar.server.es.BulkIndexer.stop(BulkIndexer.java:129) at org.sonar.server.rule.index.RuleIndexer.indexAll(RuleIndexer.java:85) at org.sonar.server.rule.index.RuleIndexer.indexOnStartup(RuleIndexer.java:72) at org.sonar.server.es.IndexerStartupTask.synchronousIndexing(IndexerStartupTask.java:83) at org.sonar.server.es.IndexerStartupTask.indexUninitializedTypes(IndexerStartupTask.java:68) at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Unknown Source) at java.base/java.util.stream.ReferencePipeline$Head.forEach(Unknown Source) at org.sonar.server.es.IndexerStartupTask.execute(IndexerStartupTask.java:53) at java.base/java.util.Optional.ifPresent(Unknown Source) at org.sonar.server.platform.platformlevel.PlatformLevelStartup$1.doPrivileged(PlatformLevelStartup.java:134) at org.sonar.server.user.DoPrivileged.execute(DoPrivileged.java:46) at org.sonar.server.platform.platformlevel.PlatformLevelStartup.start(PlatformLevelStartup.java:130)

We are on a 10.7 installation. After removing the plugin again SonarQube starts without a problem.

@tomasz-strzelecki-vml
Copy link
Collaborator Author

Ok. Thank you for your feedback. I will try to reproduce the issue and come back to you. I tried to use plugin with 10.7 instance, but I worked with clean installation without any data. In that case it worked without issues. It might be the case that new version doesn't support backward compatibility with ES indexes.

@macskay
Copy link

macskay commented Nov 20, 2024

any news on this @tomasz-strzelecki-vml ?

@tomasz-strzelecki-vml
Copy link
Collaborator Author

@macskay can you share the exact version of SonarQube server which you use?

@tomasz-strzelecki-vml
Copy link
Collaborator Author

tomasz-strzelecki-vml commented Nov 21, 2024

@macskay I tried to reproduce the issue locally but I can't. I recommend to rebuild ES indices. On 10.7-community image they are located in path /opt/sonarqube/data/es8. You have to simply:

  1. Stop your SonarQube server
  2. Remove the contents of the $SQ_HOME/data/es directory
  3. You can simply change the es directory name to keep it as backup
  4. Start the server

SonarQube will recreate indices on startup and plugin should work without issues.

@tomasz-strzelecki-vml
Copy link
Collaborator Author

@macskay any news?

@macskay
Copy link

macskay commented Nov 27, 2024

I will try that, even though I think I have. We are on SonnarQube 10.7. Will get back to you as soon as I tried out purging the es indicies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants