-
Notifications
You must be signed in to change notification settings - Fork 6
373 provdiding CRUD tests for Breadcrumb v2 component, adding needed … #15
373 provdiding CRUD tests for Breadcrumb v2 component, adding needed … #15
Conversation
…test pages, configurations and page objects
CRUD test for Breadcrumb component v2 Issue tracking: wttech/bobcat#373 |
I think you overkilled this component - you're testing multiple combinations and behaviors for this component, but what we're really supposed to test is if we can handle the configuration dialog forms with Bobcat. So instead of testing, if the component reacts properly when you increase a value, and then decrease the value, test if you can work with the dialog field for that value and if the component reflects that change.
Please remember - we're not covering the core components with tests. We're testing Bobcat to see if it's able to handle the configuration of core components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to request changes :P
…navigation start level, removig test for combining all dialog options, renaming and changing configuration of yaml files, removing not used configuration of sample test page
|
||
@Test | ||
@DisplayName("checkbox values change to true") | ||
public void changeCheckboxesToTrue() throws ActionException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You assert that the current page is not displayed in the breadcrumb component, but you don't check if the hidden page is displayed in it, right? If so, then an assertion is missing
…test pages, configurations and page objects