Skip to content
This repository has been archived by the owner on Dec 20, 2021. It is now read-only.

373 provdiding CRUD tests for Breadcrumb v2 component, adding needed … #15

Merged
merged 4 commits into from
Oct 23, 2019

Conversation

Danon9111
Copy link
Contributor

…test pages, configurations and page objects

@Danon9111
Copy link
Contributor Author

CRUD test for Breadcrumb component v2

Issue tracking: wttech/bobcat#373

@kaczymuczy
Copy link
Contributor

I think you overkilled this component - you're testing multiple combinations and behaviors for this component, but what we're really supposed to test is if we can handle the configuration dialog forms with Bobcat. So instead of testing, if the component reacts properly when you increase a value, and then decrease the value, test if you can work with the dialog field for that value and if the component reflects that change.
translating into something different

  • modifyAllProperties() - this test covers too much at the same time

  • decreaseNavigationStartLevel(), increaseNavigationStartLevel() - only one of these is needed to check if we can handle the responsible dialog field

  • hideCurrentPage(), showHiddenNavigationItems() - these both edit simple checkboxes, they can be merged into one test

  • after applying the points above maybe it's possible to reduce the number of test pages?

Please remember - we're not covering the core components with tests. We're testing Bobcat to see if it's able to handle the configuration of core components.

@kaczymuczy kaczymuczy self-requested a review October 22, 2019 07:17
Copy link
Contributor

@kaczymuczy kaczymuczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to request changes :P

…navigation start level, removig test for combining all dialog options, renaming and changing configuration of yaml files, removing not used configuration of sample test page
@Danon9111 Danon9111 requested a review from kaczymuczy October 22, 2019 20:36

@Test
@DisplayName("checkbox values change to true")
public void changeCheckboxesToTrue() throws ActionException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You assert that the current page is not displayed in the breadcrumb component, but you don't check if the hidden page is displayed in it, right? If so, then an assertion is missing

@Danon9111 Danon9111 requested a review from kaczymuczy October 23, 2019 11:29
@Danon9111 Danon9111 merged commit 4baf0c3 into master Oct 23, 2019
@kaczymuczy kaczymuczy deleted the feature/373-core-components-breadcrumbs-tests branch December 16, 2019 17:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants