Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

Handling AEM Core components #373

Open
14 of 25 tasks
mkrzyzanowski opened this issue Aug 26, 2019 · 22 comments
Open
14 of 25 tasks

Handling AEM Core components #373

mkrzyzanowski opened this issue Aug 26, 2019 · 22 comments

Comments

@mkrzyzanowski
Copy link
Contributor

mkrzyzanowski commented Aug 26, 2019

Adobe maintains a set of core components: https://github.com/adobe/aem-core-wcm-components.

The scope of this task is to investigate if Bobcat can handle authoring using these components and add such capability wherever it is not possible.

Note: we're assuming the latest version of Core components

Environment:

Components:

Template components

Page authoring components

Container components

Form components

@kaczymuczy
Copy link

I'll join, will take care of Title first

@kaczymuczy
Copy link

Next on my list is List

@kaczymuczy
Copy link

kaczymuczy commented Sep 18, 2019

Text is already covered by ConfigureComponentTest - checking it on the list as "done"

@kaczymuczy
Copy link

Next - Image

@jaskowskak
Copy link

Hi, I take care of Teaser component

@DeChrish
Copy link

DeChrish commented Oct 4, 2019

@kaczymuczy @jaskowskak @mkrzyzanowski Good Job!!

@Danon9111
Copy link
Contributor

Danon9111 commented Oct 5, 2019

I will take a look on Download component

EDIT:
Regarding AEM properties Download component is deprecated since 6.5 version
image

@barbasial
Copy link

I'm joining too. I will take care of Button component.

@kaczymuczy
Copy link

I'll put the Content Fragment now under my looking glass

@Danon9111
Copy link
Contributor

I will take a look on the Separator component

@jaskowskak
Copy link

I'll take care of Carousel

@Danon9111
Copy link
Contributor

Separator is a core component and available in AEM 6.5. Unfortunately it is not available (by default) under We Retail content. It is available only under component demo pages (../content/core-components-examples/library).

We can make it available by modifying default configuration of 'content-page' template under We Retail branch. (This need to be confirmed, if is it possible to automate this action)

We can also prepare tests for Separator component, which will work under path

/content/core-components-examples/library

Or we can drop this component.

@mkrzyzanowski @Shaihuludus what do you think?

P.S.
As I heard there is bigger number of components whit similar situation. Maybe it would be valuable to verify which components?

@jaskowskak
Copy link

jaskowskak commented Oct 14, 2019

Tests for Teaser component: wttech/bobcat-aem-tests#12

@Danon9111
Copy link
Contributor

Creating tests for Separator component will be dropped. Reasons behind it are:

  • Separator component does not have any configuration dialog
  • In default AEM solution, for Separator component Author can change only Style Variant
  • Bobcat does not support operations on Style Variants. New ticket for this is open Handling Styles Variant functionality  #392

I have also noticed that in Core Components 2.6.0 is added new component - Experience Fragment and in Core Components 2.7.0 Embed . Do we want add them to the list and create tests for them?

@Danon9111
Copy link
Contributor

I will try Sharing component this time ;)

@Danon9111
Copy link
Contributor

Sharing component need some special configuration of page properties. We can achieve this by "hard coding" this properties, but after that we don't have anything to automate. Other way is to create mechanism in Bobcat to set proper page properties. For this purpose I have create issue in main Bobcat repo - #393

For now, there is no sense to create any tests for Sharing component.

@Danon9111
Copy link
Contributor

I will work on breadcrumb right now

@barbasial
Copy link

I will try Accordion

@kaczymuczy
Copy link

I'm going for the Content Fragment List

@kaczymuczy
Copy link

Working on Tabs now

@kaczymuczy
Copy link

Going for Form Container

@kaczymuczy
Copy link

Actually I'll take all Form Components should no one protest :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants