26 implement aws ssm connection type #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| putParameterInput := &ssm.PutParameterInput{ | ||
| Name: aws.String(remotePath), | ||
| Value: aws.String(string(fileContent)), |
There was a problem hiding this comment.
how about 500 mb string ?:D
| //TODO implement me | ||
| panic("implement me") | ||
| func (a *AWSSSMConnection) Info() string { | ||
| return fmt.Sprintf("ssm: instance='%s', region='%s'", a.InstanceID, a.Region) |
There was a problem hiding this comment.
instance_id
| panic("implement me") | ||
| func (a *AWSSSMConnection) Connect() error { | ||
| // Specify the AWS region | ||
| cfg, err := config.LoadDefaultConfig(context.Background(), config.WithRegion(a.Region)) |
There was a problem hiding this comment.
whole connection should use same context
| return fmt.Errorf("ssm: error creating AWS session: %v", err) | ||
| } | ||
|
|
||
| startSessionInput := &ssm.StartSessionInput{ |
There was a problem hiding this comment.
3 lines to 1; fmt
internal/provider/instance_client.go
Outdated
| @@ -220,7 +220,7 @@ func (ic *InstanceClient) ReadStatus() (InstanceStatus, error) { | |||
|
|
|||
| func (ic *InstanceClient) bootstrap() error { | |||
| return ic.doActionOnce("bootstrap", ic.cl.WorkDir, func() error { | |||
| return ic.runScript("bootstrap", ic.data.System.Bootstrap, ".") | |||
| return ic.runScript("bootstrap", ic.data.System.Bootstrap, ic.cl.WorkDir) | |||
There was a problem hiding this comment.
some commands downloads temporary files, this is to ensure that it is done in dedicated directory
krystian-panek-vmltech
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.