chore: improve

wundergraph · Mar 14, 2024 · 1ab5c2b · 1ab5c2b
1 parent 2614475
commit 1ab5c2b
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/controlplane/src/core/composition/composer.ts b/controlplane/src/core/composition/composer.ts
@@ -158,7 +158,7 @@ export class Composer {
               secret: admissionConfig.jwtSecret,
               token: {
                 iat: nowInSeconds() + 5 * 60, // 5 minutes
-                aud: 'admission-hooks',
+                aud: 'admission-hooks', // to distinguish from other tokens
                 organization_id: organizationId,
                 federated_graph_id: composedGraph.id,
               },
@@ -256,8 +256,18 @@ export class Composer {
       }
     }
 
+    const errors: ComposeDeploymentError[] = [];
+
+    if (deploymentError) {
+      errors.push(deploymentError);
+    }
+
+    if (admissionError) {
+      errors.push(admissionError);
+    }
+
     return {
-      errors: [deploymentError, admissionError].filter(Boolean) as ComposeDeploymentError[],
+      errors,
     };
   }