Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): sync pnpm version into Dockerfiles #1335

Merged

Conversation

gpazevedo
Copy link
Contributor

Motivation and Context

=> ERROR [cdn builder 7/10] RUN pnpm install --filter=. 0.9s

[cdn builder 7/10] RUN pnpm install --filter=./cdn-server/cdn --filter=./cdn-server --frozen-lockfile:
0.821  ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version)
0.821
0.821 Your pnpm version is incompatible with "/app".
0.821
0.821 Expected version: 9
0.821 Got: 8.15.9

4 Dockerfiles have:
RUN npm install --global pnpm@8

Upgrading to:
RUN npm install --global pnpm@9

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

@gpazevedo gpazevedo marked this pull request as ready for review November 5, 2024 06:10
Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@StarpTech StarpTech added the internally-reviewed The issue has been reviewed internally. label Nov 5, 2024
@StarpTech StarpTech merged commit 0110145 into wundergraph:main Nov 5, 2024
9 of 10 checks passed
@gpazevedo gpazevedo deleted the gpazevedo/sync-pnpm-makefiles branch November 8, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controlplane internally-reviewed The issue has been reviewed internally. studio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants