Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLT-1026: Update helm unit tests to work with latest version of the helm-unittest plugin #711

Merged
merged 13 commits into from
Aug 26, 2024
Merged

SLT-1026: Update helm unit tests to work with latest version of the helm-unittest plugin #711

merged 13 commits into from
Aug 26, 2024

Conversation

Rade333
Copy link
Contributor

@Rade333 Rade333 commented Jun 17, 2024 •
edited
Loading

Blocked by wunderio/silta-images#216

Proposed changes:

  • Update helm unit tests to work with latest version of the helm-unittest plugin
  • Fix two bugs with duplicate keys in drupal-cron.yaml and varnish-deployment.yaml, reported by the updated tests

Rade333 added 12 commits June 14, 2024 12:52
@Rade333
SLT-1026: Try cicd image with upgraded helm unittests.
0bcf02b
@Rade333
SLT-1026: Remove the obsolete --helm3 flag.
1e4b493
@Rade333
SLT-1026: Added missing 'asserts' to drupal_cron_test.yaml
8513265
@Rade333
SLT-1026: Fixed yaml unmarshal error caused by duplicate definition o…
6f2715c 
…f "requests" key.
@Rade333
SLT-1026: Fix the asserted values for boolean_on and boolean_off.
d56e5bf
@Rade333
SLT-1026: Fix errors like "Error: unknown path metadata.annotations.k…
24ed7d1 
…ubernetes\.io/ingress\.class"
@Rade333
SLT-1026: Removed a duplicate livenessProbe.
9c41f12
@Rade333
SLT-1026: Explicitly define all needed template definitions at tge to…
5470762 
…p of the files, as otherwise $.Template.BasePath can't be handled properly. See helm-unittest/helm-unittest#293. Also order them alphabetically.
@Rade333
SLT-1026: Explicitly define all needed template definitions at tge to…
123e4cd 
…p of the files, as otherwise $.Template.BasePath can't be handled properly. See helm-unittest/helm-unittest#293. Also order them alphabetically.
@Rade333
SLT-1026: Explicitly define all needed template definitions at tge to…
13c8446 
…p of the files, as otherwise $.Template.BasePath can't be handled properly. See helm-unittest/helm-unittest#293. Also order them alphabetically.
@Rade333
SLT-1026: Added test "ssl redirect is enabled by default".
bc3f750
@Rade333
SLT-1026: Move back to using real image instead of test image.
2bf2913
@Rade333 Rade333 mentioned this pull request Jun 17, 2024
Merged
Jancis
Jancis approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@Jancis Jancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol at backup resource requests, don't think anyone has ever used them.
and varnish's ping, good spot!

@Rade333 Rade333 merged commit d16986b into master Aug 26, 2024
1 check failed
@Rade333 Rade333 deleted the feature/SLT-1026-helm-unittest branch August 26, 2024 12:08
@Rade333 Rade333 mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jancis Jancis Jancis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rade333 @Jancis