Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing improvements milan #104

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Testing improvements milan #104

wants to merge 14 commits into from

Conversation

toncic
Copy link

@toncic toncic commented Nov 19, 2021

Link to ticket: JIRA-123

Changes proposed in this PR:

  • change a
  • change b

How to test:

  1. do this
  2. then do that
  3. you should now see xyz

Link to feature environment:

@@ -3,10 +3,104 @@ version: 2.1
orbs:
silta: silta/[email protected]

images:
- &node
image: circleci/node:12.16.1-browsers

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node 16 LTS is out, I'd use that!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think circleci have deprecated these images in favour of convenience images (cimg). Here are the node ones:

https://circleci.com/developer/images/image/cimg/node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants