Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support connection load balancing #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sanjay-sanghavi
Copy link

Client can pass 'loadBalance' parameter to enable or disable
connection load balancing.

This should fix #27

Client can pass 'loadBalance' parameter to enable or disable
connection load balancing. Load balancing is provided by vertica
server. Even if client enables and if it is turned OFF on server,
driver should not fail.
assert.ok conn.connected
assert.notEqual conn.redirctedHost, connectionInfo.host

done()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done() should be placed to connection callback after assert

@Vanuan
Copy link
Contributor

Vanuan commented Aug 20, 2016

@wvanbergen can you review this, please? Do these tests pass?

@wvanbergen
Copy link
Owner

I am not really in the best spot the review this code, because I have not worked with either node or vertica in a long time. If someone is interested in taking over maintainership of this library, let me know.

@sanjay-sanghavi
Copy link
Author

@Vanuan unfortunately I don't have access to vertica anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for load balance connection options in Vertica 7.0?
4 participants