Add a list view to display all family members sorted by distance #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrauseFx
reviewed
Jun 3, 2017
There was a problem hiding this comment.
Hey @DaniArnaout, thanks for the PR, I love the idea of a list, however this seems to cause a lot of duplicate code, from the mapview, which will make it very hard to maintain in the future
| Database.stopListening(); | ||
| } | ||
|
|
||
| _handleAppStateChange = appState => { |
There was a problem hiding this comment.
That looks like duplicate code?
| } | ||
|
|
||
| if (coordinatesProvided && foundExisting == -1) { | ||
| let profilePictureUrl = "https://twitter.com/" + |
There was a problem hiding this comment.
You got a solid point there!
I thought about it while I was working on the list, but I just didn't have enough time to implement a data store / manager to hold one source of truth for the app.
Another quick workaround would be just passing the users array from the map to the list then display it statically (without live updates).
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can get to the list view right from the map view action sheet.
This will help members easily find & communicate with each other. 🤗