Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update product.njk #138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update product.njk #138

wants to merge 1 commit into from

Conversation

Samuel-Hoskin
Copy link

Fixes an issue where the aside on the project page is not actually to the side

Fixes an issue where the aside on the project page is not actually to the side
@paulrobertlloyd
Copy link
Collaborator

paulrobertlloyd commented Apr 25, 2023

Hi @Samuel-Hoskin, and thanks for the PR. This layout, as it stands with the aside at the bottom, is actually by design.

It’s envisaged the product page being used for a home or marketing page, where you’d want to use the full width of the page – if you look at the home page for the docs for this project, that’s what we’re doing.

The aside was added for consistency, but should you want to put it in it's own column, you’d have to create the layout as you have done in this PR, and pull in the related.njk include.

It might be possible to have it so that you could define the layout in YAML front matter somehow, or choose from different layouts, but that can soon become restrictive if you want a slightly different layout.

Open to ideas on how to deal with this. Perhaps it's more configuration options, perhaps its more layouts, I’m not sure.

What was it you were trying to achieve that led to this PR?

@paulrobertlloyd paulrobertlloyd added enhancement New feature or request question Further information is requested labels Apr 25, 2023
@paulrobertlloyd paulrobertlloyd force-pushed the main branch 7 times, most recently from 375d444 to 7f9f116 Compare December 19, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants